-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding simple Podman insecure registry support #2060
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
+ Coverage 59.10% 64.61% +5.51%
==========================================
Files 106 107 +1
Lines 13693 13703 +10
==========================================
+ Hits 8093 8854 +761
+ Misses 4783 3969 -814
- Partials 817 880 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hello!! It looks good to me. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
patch=".\"insecure-registries\" = [\"localhost:50000\""] | ||
sudo jq "$patch" /etc/docker/daemon.json > /tmp/daemon.json.tmp && sudo mv /tmp/daemon.json.tmp /etc/docker/daemon.json | ||
sudo service docker restart | ||
} | ||
|
||
set_registry_insecure_podman() { | ||
FILE="/etc/containers/registries.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be local readonly var.
Changes
/kind
Fixes #2059
Release Note
Docs