Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple Podman insecure registry support #2060

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

matzew
Copy link
Member

@matzew matzew commented Oct 30, 2023

Changes

/kind

Fixes #2059

Release Note


Docs


Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Oct 30, 2023

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7c9695) 59.10% compared to head (8dc2903) 64.61%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
+ Coverage   59.10%   64.61%   +5.51%     
==========================================
  Files         106      107       +1     
  Lines       13693    13703      +10     
==========================================
+ Hits         8093     8854     +761     
+ Misses       4783     3969     -814     
- Partials      817      880      +63     
Flag Coverage Δ
e2e-test 36.45% <ø> (?)
e2e-test-oncluster 30.43% <ø> (-0.08%) ⬇️
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.58% <ø> (?)
e2e-test-runtime-node 26.59% <ø> (?)
e2e-test-runtime-python 26.59% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.58% <ø> (?)
e2e-test-runtime-springboot 25.72% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.88% <ø> (+2.56%) ⬆️
unit-tests-macos-latest 48.77% <ø> (+0.55%) ⬆️
unit-tests-ubuntu-latest 49.53% <ø> (+0.52%) ⬆️
unit-tests-windows-latest 48.82% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor

Hello!! It looks good to me.
Just cosmetics, would you mind refine (or clean) PR description. Thanks!

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@knative-prow knative-prow bot merged commit a4680b2 into knative:main Oct 30, 2023
38 checks passed
patch=".\"insecure-registries\" = [\"localhost:50000\""]
sudo jq "$patch" /etc/docker/daemon.json > /tmp/daemon.json.tmp && sudo mv /tmp/daemon.json.tmp /etc/docker/daemon.json
sudo service docker restart
}

set_registry_insecure_podman() {
FILE="/etc/containers/registries.conf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be local readonly var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTAINER_ENGINE env var for supporting podman
3 participants