-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump faas-js-runtime and cloudevents for node & TS #1873
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
+ Coverage 60.45% 62.93% +2.48%
==========================================
Files 106 107 +1
Lines 13727 13729 +2
==========================================
+ Hits 8298 8641 +343
+ Misses 4608 4223 -385
- Partials 821 865 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/test unit-tests |
1 similar comment
/test unit-tests |
4bdc5f3
to
364b2eb
Compare
/override unit-tests_func_main |
@lance: Overrode contexts on behalf of lance: unit-tests_func_main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
@lance it looks like there is a double definition of types. |
@lance what |
When I delete |
It is weird nonetheless, I thought that |
@lholmquist any idea why this would be happening? |
The Node.js and TypeScript templates have been bumped to the latest versions of faas-js-runtime (2.2.2) and CloudEvents (7.0.1). There is an issue with the `expectType` test for TypeScript CloudEvent functions which I can't quite figure out, but the type test is not critical and does not do anything to validate other than whether the function signature is what's expected by faas-js-runtime, and in this case, I think type exported type for faas-js-runtime may actually be the issue here. Signed-off-by: Lance Ball <lball@redhat.com>
There was a change in how go parses URLs in versions higher than 1.20.2 (likely 1.20.6 and up) which breaks the Docker API's handling of daemon URIs. This fix pins the Go version at a version known to work with the existing Docker API and `func` implementation. Signed-off-by: Lance Ball <lball@redhat.com>
9cd091b
to
79aacb8
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Changes
The Node.js and TypeScript templates have been bumped to the latest versions of faas-js-runtime (2.2.2) and CloudEvents (7.0.1).
There is an issue with the
expectType
test for TypeScript CloudEvent functions which I can't quite figure out, but the type test is not critical and does not do anything to validate other than whether the function signature is what's expected by faas-js-runtime, and in this case, I think type exported type for faas-js-runtime may actually be the issue here./kind chore
Release Note
/cc @matejvasek