-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: Use jobs not plain pods for auxiliary tasks #1857
Conversation
Job should have security context set properly automatically. Signed-off-by: Matej Vasek <mvasek@redhat.com>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@grafvonb please review this and test it on AWS EKS. In particular try running on-cluster-build&re-build on EKS. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 61.90% 59.54% -2.36%
==========================================
Files 107 106 -1
Lines 13710 13710
==========================================
- Hits 8487 8164 -323
- Misses 4381 4722 +341
+ Partials 842 824 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
/retest |
I will look at this however during my current work on #1466 I get problems with the deploy task on EKS (Kubernetes v1.24). The error says that the
|
@grafvonb I don't know about the issue. Try asking in knative serving slack. Can you reproduce the issue by running |
The |
@grafvonb have you had opportunity to test this? |
@matejvasek Due to the current workload at work, I will not be able to address this issue until the weekend. My plan is to set up a new cluster, since I can't do anything with the error mentioned above. |
@matejvasek As discussed I have created today a new AWS EKS cluster with Kubernetes 1.27, latest Knative and Tekton to test this PR. The test was successful. Please find following logs with detailed information:
It would be good to have this version released asap as the current version does not work:
|
@grafvonb thaks for checking. So this PR is good to go, right? |
See also #1872 |
@grafvonb there should be release this week. |
@matejvasek Yeah, it works. To be 100% I've just built the current state of main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This reverts commit cb6f33d.
* Revert "src: Use jobs not plain pods for auxiliary tasks (#1857)" This reverts commit cb6f33d. * refactor: move code from openshift This is needed to avoid circular package dependencies. Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: set pod SC only on non-OpenShift Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
Changes
job
s instead of plainpod
s for auxiliary tasks.Rationale:
job
should have security context set properly automatically.