Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10]: src: interstitial commit version (#1817) #1850

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

lance
Copy link
Member

@lance lance commented Jul 5, 2023

This is a backport of #1817 to the 1.10 branch.

The Knative version is now included in version command verbose output

Building an unreleased version no longer returns v0.0.0, but instead the value provided by git describe --tags which is the most recent tagged release with a suffix consisting of the number of commits since that release and the short hash.

Verbose output now always includes the current commit on a dedicated line.

Improved `func --version` output

@knative-prow knative-prow bot requested a review from dsimansk July 5, 2023 20:10
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@lance lance changed the title src: interstitial commit version (#1817) [release-1.10]: src: interstitial commit version (#1817) Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +13.27 🎉

Comparison is base (d540166) 49.78% compared to head (42f3517) 63.05%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.10    #1850       +/-   ##
=================================================
+ Coverage         49.78%   63.05%   +13.27%     
=================================================
  Files                81       93       +12     
  Lines             11149    11968      +819     
=================================================
+ Hits               5550     7546     +1996     
+ Misses             5114     3737     -1377     
- Partials            485      685      +200     
Flag Coverage Δ
e2e-test 38.91% <6.66%> (?)
e2e-test-oncluster-runtime 29.60% <6.66%> (?)
e2e-test-runtime-go 28.31% <6.66%> (?)
e2e-test-runtime-node 29.45% <6.66%> (?)
e2e-test-runtime-python 29.45% <6.66%> (?)
e2e-test-runtime-quarkus 29.58% <6.66%> (?)
e2e-test-runtime-springboot 28.47% <6.66%> (?)
e2e-test-runtime-typescript 29.58% <6.66%> (?)
integration-tests 50.13% <85.71%> (?)
unit-tests-macos-latest 48.92% <85.71%> (?)
unit-tests-ubuntu-latest 49.84% <85.71%> (?)
unit-tests-windows-latest 48.95% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 80.17% <85.71%> (+2.53%) ⬆️
cmd/func/main.go 43.47% <100.00%> (ø)

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

The Knative version is now included in version command verbose output

Building an unreleased version no longer returns v0.0.0, but instead the
value provided by `git describe --tags` which is the most recent tagged
release with a suffix consisting of the number of commits since that
release and the short hash.

Verbose output now always includes the current commit on a dedicated
line.
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f38444b into knative:release-1.10 Jul 7, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants