Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: update func-runtime-go and dapr #1836

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

lkingland
Copy link
Member

Updates to dapr v1.11.1 and func-runtime-go v0.3.2

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.53 🎉

Comparison is base (4719a43) 61.98% compared to head (511912e) 63.51%.

❗ Current head 511912e differs from pull request most recent head c7f7112. Consider uploading reports for the commit c7f7112 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
+ Coverage   61.98%   63.51%   +1.53%     
==========================================
  Files         107      107              
  Lines       13727    13732       +5     
==========================================
+ Hits         8508     8722     +214     
+ Misses       4376     4168     -208     
+ Partials      843      842       -1     
Flag Coverage Δ
e2e-test 35.25% <ø> (-0.33%) ⬇️
e2e-test-oncluster ?
e2e-test-oncluster-runtime 26.68% <ø> (?)
e2e-test-runtime-go 25.63% <ø> (?)
e2e-test-runtime-python 26.58% <ø> (?)
e2e-test-runtime-springboot 25.76% <ø> (?)
integration-tests 51.73% <ø> (+2.33%) ⬆️
unit-tests-macos-latest 49.53% <ø> (+0.29%) ⬆️
unit-tests-ubuntu-latest 50.34% <ø> (+0.31%) ⬆️
unit-tests-windows-latest 49.56% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2023
@lkingland lkingland requested review from matejvasek and removed request for jrangelramos and nainaz July 4, 2023 06:38
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@lance lance added this to the Release 1.11 milestone Jul 12, 2023
@lance
Copy link
Member

lance commented Jul 12, 2023

@lkingland can you rebase this please?

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

New changes are detected. LGTM label has been removed.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@knative-prow knative-prow bot merged commit ba79840 into knative:main Jul 18, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants