Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rust templates linting #1814

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

andrejusc
Copy link
Contributor

Changes

  • Added Rust templates linting to assure needed code style quality

/kind enhancement

Release Note

Added Rust templates linting into CI workflow

Docs


@knative-prow knative-prow bot added kind/enhancement size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2023
@knative-prow knative-prow bot requested review from rhuss and vyasgun June 13, 2023 21:49
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.58 ⚠️

Comparison is base (83bc889) 62.47% compared to head (e0decde) 60.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   62.47%   60.90%   -1.58%     
==========================================
  Files         106      106              
  Lines       13483    13483              
==========================================
- Hits         8424     8212     -212     
- Misses       4264     4497     +233     
+ Partials      795      774      -21     
Flag Coverage Δ
e2e-test 37.68% <ø> (ø)
e2e-test-oncluster 33.39% <ø> (+0.09%) ⬆️
e2e-test-oncluster-runtime 28.46% <ø> (?)
e2e-test-runtime-go 27.34% <ø> (?)
e2e-test-runtime-node 28.35% <ø> (?)
e2e-test-runtime-python 28.35% <ø> (?)
e2e-test-runtime-quarkus 28.48% <ø> (?)
e2e-test-runtime-springboot 27.48% <ø> (?)
e2e-test-runtime-typescript 28.38% <ø> (?)
integration-tests ?
unit-tests-macos-latest 49.94% <ø> (ø)
unit-tests-ubuntu-latest 50.66% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 49.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrejusc, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@andrejusc
Copy link
Contributor Author

andrejusc commented Jun 14, 2023

/retest

@andrejusc
Copy link
Contributor Author

@matejvasek - is it above workflow/actions somehow stuck with "Expected — Waiting for status to be reported" ?

@knative-prow knative-prow bot merged commit f6c11c9 into knative:main Jun 14, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants