Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad connection handling for in cluster dialer #1800

Merged
merged 4 commits into from
Jun 19, 2023
Merged

fix: bad connection handling for in cluster dialer #1800

merged 4 commits into from
Jun 19, 2023

Commits on Jun 8, 2023

  1. fix: bad connection handling for in cluster dialer 

    Connections were closed from wrong end of io.Pipe
which resulted in confusing error logs.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
    @matejvasek
    matejvasek committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a02623f View commit details
    Browse the repository at this point in the history

  2. feat: DialContext() better error handling 

    Now DialContext() returns some errors immediately
instead of deferring it Read/Write operation on the returned connection.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
    @matejvasek
    matejvasek committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    823f03a View commit details
    Browse the repository at this point in the history

  3. feat: DialContext() more better error handling 

    Now ContextDial() tries to parse socat's stderr and translate it to Go's net.OpError
instead of just creating error with whole stderr embedded in it.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
    @matejvasek
    matejvasek committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9158617 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Lance Ball <lball@redhat.com>
    @matejvasek @lance
    matejvasek and lance committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7a18b2f View commit details
    Browse the repository at this point in the history