-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Rust cloudevents example #1799
Conversation
When modifying templates the |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
+ Coverage 62.50% 63.63% +1.13%
==========================================
Files 106 106
Lines 13422 13422
==========================================
+ Hits 8389 8541 +152
+ Misses 4246 4071 -175
- Partials 787 810 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94e1969
to
1ff2ad5
Compare
Thank you for the hint @matejvasek, updated the generated file. |
/approve |
By: - Using a more opinionated release profile to optimize binary - Removing not required dependencies - Updating the rest of the dependencies - Switch to Rust edition 2021 - Cleanup imports by importing the concrete types - Avoid unnecessary type assertions - Do not unwrap port Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
1ff2ad5
to
35364d4
Compare
Rebased on top of main. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup
Release Note
Docs