-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding default builders #1796
adding default builders #1796
Conversation
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Welcome @nitishchauhan0022! It looks like this is your first PR to knative/func 🎉 |
@lance hey, can I add this environment config option for output format |
that would be nice! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 62.55% 63.56% +1.01%
==========================================
Files 106 106
Lines 13417 13439 +22
==========================================
+ Hits 8393 8543 +150
+ Misses 4237 4086 -151
- Partials 787 810 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmd/environment.go
Outdated
SocatImage: k8s.SocatImage, | ||
TarImage: k8s.TarImage, | ||
Languages: r, | ||
DefaultBuilders: s2i.DefaultBuilderImages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about pack
builders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL i have added that
Yes - agreed. Please feel free! |
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for the contribution @nitishchauhan0022!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, nitishchauhan0022 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "style / suggester / shell" |
@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Added the default builders variables for listing through func environment command
Fixes #1788