Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding default builders #1796

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

nitishchauhan0022
Copy link
Contributor

@nitishchauhan0022 nitishchauhan0022 commented Jun 8, 2023

Changes

Added the default builders variables for listing through func environment command

Fixes #1788

Adds default builders for s2i and buildpacks to `func environment`

Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 8, 2023

Welcome @nitishchauhan0022! It looks like this is your first PR to knative/func 🎉

@knative-prow knative-prow bot requested review from dsimansk and vyasgun June 8, 2023 04:35
@nitishchauhan0022
Copy link
Contributor Author

@lance hey, can I add this environment config option for output format

@zroubalik
Copy link
Contributor

@lance hey, can I add this environment config option for output format

that would be nice!

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 16.12% and project coverage change: +1.01 🎉

Comparison is base (6b97fb5) 62.55% compared to head (6a1746e) 63.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
+ Coverage   62.55%   63.56%   +1.01%     
==========================================
  Files         106      106              
  Lines       13417    13439      +22     
==========================================
+ Hits         8393     8543     +150     
+ Misses       4237     4086     -151     
- Partials      787      810      +23     
Flag Coverage Δ
e2e-test 37.67% <16.12%> (-0.05%) ⬇️
e2e-test-oncluster 33.28% <16.12%> (-0.02%) ⬇️
e2e-test-oncluster-runtime 28.57% <16.12%> (?)
e2e-test-runtime-go 27.22% <16.12%> (?)
e2e-test-runtime-node 28.38% <16.12%> (?)
e2e-test-runtime-python 28.38% <16.12%> (?)
e2e-test-runtime-quarkus 28.50% <16.12%> (?)
e2e-test-runtime-springboot 27.46% <16.12%> (?)
e2e-test-runtime-typescript 28.50% <16.12%> (?)
integration-tests 52.10% <16.12%> (+3.59%) ⬆️
unit-tests-macos-latest 49.86% <16.12%> (-0.02%) ⬇️
unit-tests-ubuntu-latest 50.66% <16.12%> (-0.02%) ⬇️
unit-tests-windows-latest 49.91% <16.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/builders/buildpacks/builder.go 66.94% <ø> (ø)
cmd/environment.go 20.33% <16.12%> (-0.46%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

SocatImage: k8s.SocatImage,
TarImage: k8s.TarImage,
Languages: r,
DefaultBuilders: s2i.DefaultBuilderImages,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pack builders?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL i have added that

@lance
Copy link
Member

lance commented Jun 8, 2023

@lance hey, can I add this environment config option for output format

that would be nice!

Yes - agreed. Please feel free!

cmd/environment.go Outdated Show resolved Hide resolved
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
cmd/environment.go Outdated Show resolved Hide resolved
Signed-off-by: ntishchauhan0022 <nitishchauhan0022@gmail.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2023
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks for the contribution @nitishchauhan0022!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, nitishchauhan0022

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@lance
Copy link
Member

lance commented Jun 13, 2023

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

@knative-prow
Copy link

knative-prow bot commented Jun 13, 2023

@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml

In response to this:

/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit d3a6d6c into knative:main Jun 14, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default builders to func environment
4 participants