Fix appending SHA256 hash to image reference in ImageWithDigest

[mvinkler]

Changes

• 🐛 Fix appending SHA256 hash to image reference in ImageWithDigest

/kind bug

Fixes #1768

Fixes a bug when appending SHA256 hash to image reference

[jrangelramos]

/cc @lance

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.06 🎉

Comparison is base (1b6414d) 61.81% compared to head (cfa5cb1) 62.87%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   61.81%   62.87%   +1.06%     
==========================================
  Files         101      101              
  Lines       13370    13374       +4     
==========================================
+ Hits         8264     8409     +145     
+ Misses       4309     4143     -166     
- Partials      797      822      +25     

Flag	Coverage Δ
e2e-test	37.75% <25.00%> (-0.01%)	⬇️
e2e-test-oncluster	33.35% <25.00%> (-0.01%)	⬇️
e2e-test-oncluster-runtime	28.63% <0.00%> (?)
e2e-test-runtime-go	27.27% <25.00%> (?)
e2e-test-runtime-quarkus	28.56% <25.00%> (?)
e2e-test-runtime-springboot	27.51% <25.00%> (?)
integration-tests	49.24% <25.00%> (+1.39%)	⬆️
unit-tests-macos-latest	49.18% <100.00%> (+0.06%)	⬆️
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	49.23% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/functions/function.go	84.69% <100.00%> (+1.19%)	⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lance]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, mvinkler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lance]

/cherry-pick release-1.10

[knative-prow-robot]

@lance: new pull request created: #1846

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.