feat: source-defined buildpacks #1774
Conversation
Allows buildpacks to be updated by updating to a newer version of func. Previously, buildpacs were fixed at time of function creation without a manual edit of func.yaml. Currently using Go as the reference implementation in this commit.
knative-prow
bot
added
the
kind/cleanup
knative-prow
bot
added
size/M
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
==========================================
- Coverage 62.40% 62.29% -0.12%
==========================================
Files 99 100 +1
Lines 13208 13315 +107
==========================================
+ Hits 8242 8294 +52
- Misses 4170 4226 +56
+ Partials 796 795 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lkingland
requested review from
lance,
salaboy,
zroubalik,
aslom and
matejvasek
and removed request for
navidshaikh and
vyasgun
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I really dislike this. What if somebody is using custom builder that does not need these additional buildpacks? There is no way to remove them from build. When it's in func.yaml user can alter behaviour. |
Allows buildpacks to be updated by updating to a newer version of func. Previously, buildpacks were fixed at time of function creation without a manual edit of func.yaml. Currently using Go as the reference implementation in this commit.
/kind cleanup