-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PVCSize resets to default with futureproofing #1771
Conversation
Refactors PVCSize to treat the Function member as a custom setting, and the in-code constant as the default. - Fixes a bug where the PVCSize would reset to the default on deploy - Allows the default to be changed by future func version, only pinning the value if explicitly requested by the user.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1771 +/- ##
==========================================
+ Coverage 62.04% 62.28% +0.23%
==========================================
Files 100 100
Lines 13311 13312 +1
==========================================
+ Hits 8259 8291 +32
+ Misses 4253 4226 -27
+ Partials 799 795 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refactors PVCSize to treat the Function member as a custom setting, and the in-code constant as the default.
/kind bug