fix: PVCSize resets to default with futureproofing #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors PVCSize to treat the Function member as a custom setting, and the in-code constant as the default. - Fixes a bug where the PVCSize would reset to the default on deploy - Allows the default to be changed by future func version, only pinning the value if explicitly requested by the user.
knative-prow
bot
added
kind/bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1771 +/- ##
==========================================
+ Coverage 62.04% 62.28% +0.23%
==========================================
Files 100 100
Lines 13311 13312 +1
==========================================
+ Hits 8259 8291 +32
+ Misses 4253 4226 -27
+ Partials 799 795 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lkingland
requested review from
lance,
salaboy,
zroubalik,
aslom and
matejvasek
and removed request for
jrangelramos and
nainaz
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors PVCSize to treat the Function member as a custom setting, and the in-code constant as the default.
/kind bug