Pipeline as Code integration for GitLab #1769

matejvasek · 2023-05-31T20:41:29Z

Changes

🎁 Pipeline as Code integration for GitLab.
🧪 Host names falling under the 127.0.0.1.sslip.io domains are now resolved to cluster node IP inside of the cluster.

/kind enhancement

feat: pipeline as code integration for gitlab

codecov · 2023-05-31T21:27:49Z

Codecov Report

Patch coverage: 10.14% and project coverage change: +0.83 🎉

Comparison is base (fea4a72) 62.04% compared to head (d42e640) 62.88%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   62.04%   62.88%   +0.83%     
==========================================
  Files         100      101       +1     
  Lines       13311    13368      +57     
==========================================
+ Hits         8259     8406     +147     
+ Misses       4253     4139     -114     
- Partials      799      823      +24

Flag	Coverage Δ
e2e-test	`37.78% <1.44%> (-0.17%)`	⬇️
e2e-test-oncluster	`33.37% <1.44%> (-0.15%)`	⬇️
e2e-test-oncluster-runtime	`28.69% <1.44%> (?)`
e2e-test-runtime-go	`27.34% <1.44%> (?)`
e2e-test-runtime-node	`28.41% <1.44%> (?)`
e2e-test-runtime-python	`28.41% <1.44%> (?)`
e2e-test-runtime-quarkus	`28.54% <1.44%> (?)`
e2e-test-runtime-springboot	`27.40% <1.44%> (?)`
e2e-test-runtime-typescript	`28.54% <1.44%> (?)`
integration-tests	`49.28% <15.21%> (+1.43%)`	⬆️
unit-tests-macos-latest	`49.16% <4.34%> (?)`
unit-tests-ubuntu-latest	`49.98% <4.34%> (-0.13%)`	⬇️
unit-tests-windows-latest	`49.21% <4.34%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/git/github/github.go	`0.00% <0.00%> (ø)`
pkg/git/gitlab/gitlab.go	`0.00% <0.00%> (ø)`
pkg/git/git.go	`44.61% <3.33%> (-29.68%)`	⬇️
pkg/pipelines/tekton/pipelines_pac_provider.go	`43.79% <25.00%> (+39.33%)`	⬆️
pkg/pipelines/tekton/pipeplines_provider.go	`55.52% <41.66%> (-0.81%)`	⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Resolve '[*.]127.0.0.1.sslip.io' to cluster node IP. Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek · 2023-06-02T17:48:36Z

@zroubalik PTAL

lkingland

big 👍🏻 from me. Glad to see GitLab support

The tests look sufficient, but /hold ing for others to take a look since this is a... hefty PR
/lgtm
/hold

pkg/pipelines/tekton/gitlab_test.go

zroubalik

/lgtm

Great! Thanks for implementing this!

knative-prow · 2023-06-05T09:47:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lkingland,matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

matejvasek · 2023-06-05T11:21:19Z

@lance @zroubalik we need to override the linter error.

zroubalik · 2023-06-05T11:43:09Z

/override "Code Style / style / suggester / shell (pull_request)"

knative-prow · 2023-06-05T11:43:12Z

@zroubalik: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Code Style / style / suggester / shell (pull_request)

Only the following failed contexts/checkruns were expected:

EasyCLA
style / suggester / shell
style / suggester / yaml
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code Style / style / suggester / shell (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zroubalik · 2023-06-05T11:43:40Z

/override "style / suggester / shell"

knative-prow · 2023-06-05T11:43:43Z

@zroubalik: Overrode contexts on behalf of zroubalik: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matejvasek · 2023-06-05T12:29:49Z

@jrangelramos @lance PTAL

matejvasek · 2023-06-05T19:47:29Z

/unhold

knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2023

knative-prow bot requested review from navidshaikh and rhuss May 31, 2023 20:41

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023

matejvasek removed request for rhuss and navidshaikh May 31, 2023 20:45

feat: PaC for Gitlab

ac49b98

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek force-pushed the pac-gitlab branch from 072c21a to ac49b98 Compare June 1, 2023 20:45

matejvasek requested review from zroubalik and jrangelramos June 1, 2023 20:47

matejvasek added 4 commits June 2, 2023 19:24

fixup: different approach to hostname resolution

3fbc656

Resolve '[*.]127.0.0.1.sslip.io' to cluster node IP. Signed-off-by: Matej Vasek <mvasek@redhat.com>

fixup: error handling

73c6137

Signed-off-by: Matej Vasek <mvasek@redhat.com>

fixup: added TODO

3fa075e

Signed-off-by: Matej Vasek <mvasek@redhat.com>

fixup: small refactor

d42e640

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek changed the title ~~[WIP] Pipeline as Code integration for GitLab~~ Pipeline as Code integration for GitLab Jun 2, 2023

matejvasek marked this pull request as ready for review June 2, 2023 17:47

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023

knative-prow bot requested review from nainaz and navidshaikh June 2, 2023 17:47

matejvasek requested review from lance and lkingland and removed request for nainaz and navidshaikh June 2, 2023 17:47

lkingland approved these changes Jun 5, 2023

View reviewed changes

pkg/pipelines/tekton/gitlab_test.go Show resolved Hide resolved

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023

knative-prow bot assigned lkingland Jun 5, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023

zroubalik approved these changes Jun 5, 2023

View reviewed changes

knative-prow bot assigned zroubalik Jun 5, 2023

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023

knative-prow bot merged commit 4e74368 into knative:main Jun 5, 2023
2 checks passed

lance mentioned this pull request Jun 7, 2023

feat: start timeout for host runs #1782

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipeline as Code integration for GitLab #1769

Pipeline as Code integration for GitLab #1769

matejvasek commented May 31, 2023 •

edited

Loading

codecov bot commented May 31, 2023 •

edited

Loading

matejvasek commented Jun 2, 2023

lkingland left a comment

zroubalik left a comment

knative-prow bot commented Jun 5, 2023

matejvasek commented Jun 5, 2023

zroubalik commented Jun 5, 2023

knative-prow bot commented Jun 5, 2023

zroubalik commented Jun 5, 2023

knative-prow bot commented Jun 5, 2023

matejvasek commented Jun 5, 2023

matejvasek commented Jun 5, 2023

Pipeline as Code integration for GitLab #1769

Pipeline as Code integration for GitLab #1769

Conversation

matejvasek commented May 31, 2023 • edited Loading

Changes

codecov bot commented May 31, 2023 • edited Loading

Codecov Report

matejvasek commented Jun 2, 2023

lkingland left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

knative-prow bot commented Jun 5, 2023

matejvasek commented Jun 5, 2023

zroubalik commented Jun 5, 2023

knative-prow bot commented Jun 5, 2023

zroubalik commented Jun 5, 2023

knative-prow bot commented Jun 5, 2023

matejvasek commented Jun 5, 2023

matejvasek commented Jun 5, 2023

matejvasek commented May 31, 2023 •

edited

Loading

codecov bot commented May 31, 2023 •

edited

Loading