-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline as Code integration for GitLab #1769
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
==========================================
+ Coverage 62.04% 62.88% +0.83%
==========================================
Files 100 101 +1
Lines 13311 13368 +57
==========================================
+ Hits 8259 8406 +147
+ Misses 4253 4139 -114
- Partials 799 823 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Resolve '[*.]127.0.0.1.sslip.io' to cluster node IP. Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@zroubalik PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big 👍🏻 from me. Glad to see GitLab support
The tests look sufficient, but /hold ing for others to take a look since this is a... hefty PR
/lgtm
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great! Thanks for implementing this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lance @zroubalik we need to override the linter error. |
/override "Code Style / style / suggester / shell (pull_request)" |
@zroubalik: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "style / suggester / shell" |
@zroubalik: Overrode contexts on behalf of zroubalik: style / suggester / shell In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jrangelramos @lance PTAL |
/unhold |
Changes
127.0.0.1.sslip.io
domains are now resolved to cluster node IP inside of the cluster./kind enhancement