-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds a func environment
command
#1761
Conversation
Adds `func environment` to print the current function execution environment as JSON. See: knative#1676 Signed-off-by: Lance Ball <lball@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 60.34% 62.27% +1.93%
==========================================
Files 98 100 +2
Lines 13205 13311 +106
==========================================
+ Hits 7969 8290 +321
+ Misses 4456 4226 -230
- Partials 780 795 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The code style errors are catching the /override "style / Golang / Lint" |
@lance: Overrode contexts on behalf of lance: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
/override "style / suggester / shell" |
@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / shell, style / suggester / yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This /lgtm! /hold for anyone else to perhaps comment, but seems to me this is a great place to start iterating if we think of anything else to add, etc. |
it looks good to me. Maybe one very small cosmetic suggestion would be not printing null.. i.e. when no func env var is defined.
what about?
but this is cosmetic.. |
It might be a bit late for this PR (maybe for another).. but what about a For example, an human readable could look like
|
Signed-off-by: Lance Ball <lball@redhat.com>
@jrangelramos I assumed that would follow in a subsequent PR and have that as a TODO here: https://github.com/knative/func/pull/1761/files#diff-307b508c3eb9b3182cd02cbf3b681ab8f07937ce80be379fdd361bc9c5387d80R154 Seems like it could be a |
@jrangelramos @matejvasek thanks for the feedback; I've incorporated it (for additional output formats, I will create an Issue). |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@lance you need to override the linter. |
/override "style / Golang / Lint |
@lance: Overrode contexts on behalf of lance: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.10 |
@lance: new pull request created: #1848 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
func environment
to print the current function execution environment as JSON.See: #1676
/kind enhancement
Example output
Release Note