Pass image with digest to the deploy task

[matejvasek]

Changes

• The pack build task result IMAGE_DIGEST is passed to the deploy task. Before this was done only for the s2i build.
• The deploy task explicitly sets the --image flag.

- On-cluster build: The `pack` build task result `IMAGE_DIGEST` is passed to the deploy task.
- On-cluster build: The deploy task explicitly sets the `--image` flag.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.78 🎉

Comparison is base (bc39a1a) 60.82% compared to head (bc7b09f) 62.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
+ Coverage   60.82%   62.61%   +1.78%     
==========================================
  Files          98       99       +1     
  Lines       13066    13202     +136     
==========================================
+ Hits         7947     8266     +319     
+ Misses       4360     4143     -217     
- Partials      759      793      +34     

Flag	Coverage Δ
e2e-test	38.10% <0.00%> (-0.37%)	⬇️
e2e-test-oncluster	33.68% <100.00%> (?)
e2e-test-oncluster-runtime	28.87% <100.00%> (?)
e2e-test-runtime-go	27.52% <0.00%> (?)
e2e-test-runtime-node	28.61% <0.00%> (?)
e2e-test-runtime-python	28.61% <0.00%> (?)
e2e-test-runtime-quarkus	28.73% <0.00%> (?)
e2e-test-runtime-springboot	27.67% <0.00%> (?)
e2e-test-runtime-typescript	28.73% <0.00%> (?)
integration-tests	48.29% <0.00%> (-2.17%)	⬇️
unit-tests-macos-latest	49.55% <100.00%> (+0.17%)	⬆️
unit-tests-ubuntu-latest	50.37% <100.00%> (+0.13%)	⬆️
unit-tests-windows-latest	49.60% <100.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/pipelines/tekton/resources.go	97.12% <100.00%> (+45.01%)	⬆️
pkg/pipelines/tekton/tasks.go	100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lance]

This looks good to me @matejvasek. But I'm a little confused. How is this working now?

[matejvasek]

@lance Before only s2i passed digest via task result. The pack task passed it somehow via func.yaml (on shared volume). This PR unifies behaviour, so both use task result which is then used as the image parameter for the deploy task.

With this the image is explicitly set via --image flag. I think that's safer because if the flag is not set and func.yaml has some discrepancy between registry/image weird things happen.

[lance]

@matejvasek thanks for explaining
/lgtm

[matejvasek]

/unhold