Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require credentials when not configuring webhook #1743

Merged
merged 1 commit into from
May 18, 2023

Conversation

zroubalik
Copy link
Contributor

Changes

  • 🐛 don't require credentials when not configuring webhook

/kind bug

Fixes #1725

Release Note

don't require credentials when not configuring webhook

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label May 17, 2023
@knative-prow knative-prow bot requested review from maximilien and vyasgun May 17, 2023 08:26
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2023
@zroubalik zroubalik requested review from matejvasek, jrangelramos and lkingland and removed request for maximilien and vyasgun May 17, 2023 08:26
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (94c81d4) 60.80% compared to head (b260a7a) 60.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
+ Coverage   60.80%   60.93%   +0.13%     
==========================================
  Files          94       94              
  Lines       12343    12350       +7     
==========================================
+ Hits         7505     7526      +21     
+ Misses       4149     4137      -12     
+ Partials      689      687       -2     
Flag Coverage Δ
e2e-test 38.65% <0.00%> (-0.06%) ⬇️
e2e-test-oncluster 34.18% <0.00%> (+<0.01%) ⬆️
e2e-test-oncluster-runtime 29.33% <0.00%> (?)
e2e-test-runtime-go 27.92% <0.00%> (?)
e2e-test-runtime-node 29.02% <0.00%> (?)
e2e-test-runtime-python 29.02% <0.00%> (?)
e2e-test-runtime-springboot 28.07% <0.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 49.69% <0.00%> (-0.06%) ⬇️
unit-tests-windows-latest 48.88% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/config_git_set.go 24.24% <0.00%> (-0.76%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@knative-prow
Copy link

knative-prow bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a0b9a86 into knative:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAC Bad credentials error when not configuring webhook
2 participants