Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: host-based scaffolded function runner #1733

Merged
merged 2 commits into from
May 24, 2023

Conversation

lkingland
Copy link
Member

  • 🎁 host-based scaffolded function runner

/kind enhancement

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 10, 2023
@knative-prow
Copy link

knative-prow bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2023
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 59.33% and project coverage change: +0.24 🎉

Comparison is base (bf01e64) 62.38% compared to head (009ed61) 62.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
+ Coverage   62.38%   62.62%   +0.24%     
==========================================
  Files          98       99       +1     
  Lines       13066    13207     +141     
==========================================
+ Hits         8151     8271     +120     
- Misses       4130     4143      +13     
- Partials      785      793       +8     
Flag Coverage Δ
e2e-test 38.08% <8.00%> (-0.29%) ⬇️
e2e-test-oncluster 33.70% <6.00%> (-0.25%) ⬇️
e2e-test-oncluster-runtime 28.90% <6.00%> (?)
e2e-test-runtime-go 27.42% <6.00%> (?)
e2e-test-runtime-node 28.60% <6.00%> (?)
e2e-test-runtime-python 28.60% <6.00%> (?)
e2e-test-runtime-quarkus 28.72% <6.00%> (?)
e2e-test-runtime-springboot 27.66% <6.00%> (?)
e2e-test-runtime-typescript 28.72% <6.00%> (?)
integration-tests 48.23% <6.66%> (-2.26%) ⬇️
unit-tests-macos-latest 49.54% <58.66%> (+0.14%) ⬆️
unit-tests-ubuntu-latest 50.39% <58.66%> (+0.15%) ⬆️
unit-tests-windows-latest 49.62% <58.66%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/functions/runner.go 57.34% <57.34%> (ø)
pkg/docker/runner.go 66.66% <100.00%> (ø)
pkg/functions/client.go 64.27% <100.00%> (+0.15%) ⬆️
pkg/functions/job.go 61.64% <100.00%> (+0.53%) ⬆️
pkg/functions/template.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 14, 2023
This was referenced May 16, 2023
@lkingland lkingland force-pushed the scaffolding-host-runner branch 7 times, most recently from 97312c4 to dc4c4e7 Compare May 18, 2023 23:32
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2023
@lkingland lkingland marked this pull request as ready for review May 18, 2023 23:40
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@knative-prow knative-prow bot requested a review from nainaz May 18, 2023 23:40
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few minor comments.

pkg/functions/runner.go Show resolved Hide resolved
pkg/functions/runner.go Outdated Show resolved Hide resolved
pkg/functions/runner.go Outdated Show resolved Hide resolved
@lkingland
Copy link
Member Author

Thanks for the review @lance. Your improvements to the PR have been made

@lance
Copy link
Member

lance commented May 24, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@knative-prow knative-prow bot merged commit b82a5a4 into knative:main May 24, 2023
@lkingland lkingland added this to the Release 1.11 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants