Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oci directory pusher #1702

Merged
merged 2 commits into from
May 18, 2023
Merged

feat: oci directory pusher #1702

merged 2 commits into from
May 18, 2023

Conversation

lkingland
Copy link
Member

  • 🎁 adds a basic pusher for oci-formatted directories

For use by the initial implementation of Scaffolding, this is a basic container pusher which sends a directory which is formatted according to the OCI standard to a given registry using the default keychain, insecurely, or using explicit creds.

/kind enhancement

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Apr 25, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 25, 2023
@lkingland lkingland changed the title feat: add oci pusher feat: oci directory pusher Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (9a790f0) 62.64% compared to head (003f0ac) 62.44%.

❗ Current head 003f0ac differs from pull request most recent head 3e073da. Consider uploading reports for the commit 3e073da to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
- Coverage   62.64%   62.44%   -0.21%     
==========================================
  Files          97       95       -2     
  Lines       12906    12383     -523     
==========================================
- Hits         8085     7732     -353     
+ Misses       4054     3950     -104     
+ Partials      767      701      -66
Flag Coverage Δ
e2e-test 38.73% <ø> (+0.13%) ⬆️
e2e-test-oncluster 34.16% <ø> (-0.08%) ⬇️
e2e-test-oncluster-runtime 29.31% <ø> (?)
e2e-test-runtime-go 27.90% <ø> (?)
e2e-test-runtime-node 29.00% <ø> (?)
e2e-test-runtime-python 29.00% <ø> (?)
e2e-test-runtime-quarkus 29.13% <ø> (?)
e2e-test-runtime-springboot 28.05% <ø> (?)
e2e-test-runtime-typescript 29.13% <ø> (?)
integration-tests 49.92% <0.00%> (-0.81%) ⬇️
unit-tests-macos-latest 48.37% <0.00%> (-1.09%) ⬇️
unit-tests-ubuntu-latest 49.29% <0.00%> (-0.98%) ⬇️
unit-tests-windows-latest 48.45% <0.00%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/oci/pusher.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland mentioned this pull request Apr 25, 2023
Closed
14 tasks
@lkingland lkingland marked this pull request as ready for review April 28, 2023 06:22
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2023
lance
lance reviewed May 4, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I see @matejvasek and I are making the same comments - I'll stop now.

/lgtm
/hold for requested changes

Makefile Outdated Show resolved Hide resolved
pkg/oci/pusher_test.go Outdated Show resolved Hide resolved
test/e2e/scenario_runtime-cloudevents_test.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
lance
lance reviewed May 9, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold to remove debugging output

pkg/oci/pusher.go Outdated Show resolved Hide resolved
pkg/oci/pusher.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 9, 2023
@lkingland lkingland force-pushed the scaffolding-oci-pusher branch 4 times, most recently from 0d2a25a to 2f1ebac Compare May 15, 2023 23:36
@lkingland lkingland marked this pull request as draft May 16, 2023 00:01
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@lance
Copy link
Member

lance commented May 18, 2023

/hold cancel
/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 18, 2023
@lance
Copy link
Member

lance commented May 18, 2023

/hold cancel

@lance
Copy link
Member

lance commented May 18, 2023

@lkingland this is still marked as a work in progress - is it ready to go?

@lkingland lkingland marked this pull request as ready for review May 18, 2023 23:18
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@knative-prow knative-prow bot requested review from jrangelramos and rhuss May 18, 2023 23:18
@knative-prow knative-prow bot merged commit bf01e64 into knative:main May 18, 2023
@lkingland
Copy link
Member Author

@lkingland this is still marked as a work in progress - is it ready to go?

Yes, I am trying a slightly new process. To reduce complexity and thus my cognitive load, I am structuring these Scaffolding-related PRs as being strictly serially processed, presuming a latter PR depends on the one prior in all cases (even when in theory it could be merged concurrently).

Since the prior PR was merged, this one could be taken out of draft and merged as well, but this way its preserving the order.

So far this small capitulation has led to an appreciable improvement in my workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek left review comments

@lance lance Awaiting requested review from lance

@salaboy salaboy Awaiting requested review from salaboy

@zroubalik zroubalik Awaiting requested review from zroubalik

@aslom aslom Awaiting requested review from aslom

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Functions WG Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkingland @lance @matejvasek