-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: func domain route #1690
feat: func domain route #1690
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
+ Coverage 61.26% 62.95% +1.69%
==========================================
Files 93 93
Lines 12049 12189 +140
==========================================
+ Hits 7382 7674 +292
+ Misses 4004 3818 -186
- Partials 663 697 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
8e04b97
to
a1366bd
Compare
Note, related to #1666, it would be best if we had a way to inspect the state of the current platform upon which the function will be deployed, and issue a warning if this flag will not work as intended, and ideally have a tab-completion UX for choosing the domain for the function's route when more than one are configured. |
a1366bd
to
d00423c
Compare
d00423c
to
8f2d23a
Compare
8f2d23a
to
debca9f
Compare
Adds the --domain flag which, when provided sets the value of the func.domain label on the deployed knative service. The cluster can then use this to choose which route to create for multi-route clusters. Optional.
debca9f
to
5e048d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is a nice addition which will also be useful in clusters that have staging
and/or test
domains.
Adds the --domain flag which, when provided sets the value of the
func.domain
label on the deployed knative service. The cluster can then use this to choose which route to create for multi-route clusters. Optional.Note that this will have no effect unless the cluster is configured to apply routes based on a domain mapping in the
config-domain
config map. This feature is functional in dev and a future PR will add this configuration both to the cluster created via CI/CD.Documenting this feature is still an open question, but here us an example of a cluster configuration which by default exposes functions internally only as
function.namespace.cluster.local
, and allows for functions to be selectively exposed using the --domain flag for boson-project.org or boson-project.net:/kind enhancement