Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom health checks for node and typescript #1682

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

lance
Copy link
Member

@lance lance commented Apr 17, 2023

Changes

This commit bumps the faas-js-runtime for Node.js and TypeScript dependencies to version 1.1.0, which includes an API allowing function developers to override the liveness and readiness checks for their functions.

/kind enhancement

Release Note

Enables custom health checks for Node.js and TypeScript functions

This commit bumps the faas-js-runtime for Node.js and TypeScript
dependencies to version 1.1.0, which includes an API allowing function
developers to override the liveness and readiness checks for their
functions.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2023
@knative-prow knative-prow bot requested review from rhuss and vyasgun April 17, 2023 18:39
Signed-off-by: Lance Ball <lball@redhat.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.21 🎉

Comparison is base (71ef28c) 62.68% compared to head (5429ac3) 62.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   62.68%   62.89%   +0.21%     
==========================================
  Files          93       93              
  Lines       11967    11967              
==========================================
+ Hits         7501     7527      +26     
+ Misses       3783     3760      -23     
+ Partials      683      680       -3     
Flag Coverage Δ
e2e-test 38.86% <ø> (ø)
e2e-test-oncluster 34.61% <ø> (-0.03%) ⬇️
e2e-test-oncluster-runtime 29.56% <ø> (?)
e2e-test-runtime-go 28.16% <ø> (?)
e2e-test-runtime-node 29.40% <ø> (?)
e2e-test-runtime-python 29.40% <ø> (?)
e2e-test-runtime-quarkus 29.53% <ø> (?)
e2e-test-runtime-springboot 28.32% <ø> (?)
e2e-test-runtime-typescript 29.53% <ø> (?)
integration-tests 49.33% <ø> (-0.07%) ⬇️
unit-tests-macos-latest 48.20% <ø> (ø)
unit-tests-ubuntu-latest 49.13% <ø> (ø)
unit-tests-windows-latest 48.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 177c15b into knative:main Apr 25, 2023
@lance lance deleted the node-typescript-health-check branch April 28, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants