Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PAC - try to read git info from local .git config #1635

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Mar 20, 2023

Changes

  • 🎁 PAC - try to read git info from local .git config

/kind enhancement

On cluster builds initiated from the CLI attempt to read git configuration settings from the local .git config

Relates: #1323

@knative-prow
Copy link

knative-prow bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.72 ⚠️

Comparison is base (99de349) 62.62% compared to head (92e648b) 60.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   62.62%   60.90%   -1.72%     
==========================================
  Files          93       93              
  Lines       11911    11918       +7     
==========================================
- Hits         7459     7259     -200     
- Misses       3764     3995     +231     
+ Partials      688      664      -24     
Flag Coverage Δ
e2e-test 38.77% <0.00%> (-0.06%) ⬇️
e2e-test-oncluster ?
e2e-test-runtime-go 28.13% <0.00%> (?)
e2e-test-runtime-node 29.27% <0.00%> (?)
e2e-test-runtime-python 29.27% <0.00%> (?)
e2e-test-runtime-quarkus 29.41% <0.00%> (?)
e2e-test-runtime-springboot 28.29% <0.00%> (?)
e2e-test-runtime-typescript 29.41% <0.00%> (?)
integration-tests 49.30% <0.00%> (+<0.01%) ⬆️
unit-tests-macos-latest 48.08% <0.00%> (-0.01%) ⬇️
unit-tests-ubuntu-latest 48.99% <0.00%> (-0.06%) ⬇️
unit-tests-windows-latest 47.96% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/config_git_set.go 25.83% <0.00%> (-0.90%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2023
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@knative-prow knative-prow bot merged commit 85d3d02 into knative:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants