Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include --builder option on func run command #1614

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

manoelmarques
Copy link
Contributor

Changes

  • 🎁 Include --builder option on func run command

/kind api-change

Fixes #1609

Release Note

A new option "--builder" added to "run" command to be used when building.
Default is "pack"

Docs


@knative-prow knative-prow bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 89.65% and project coverage change: +3.23 🎉

Comparison is base (b03ada6) 58.69% compared to head (043dcea) 61.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
+ Coverage   58.69%   61.92%   +3.23%     
==========================================
  Files          82       92      +10     
  Lines       10924    11644     +720     
==========================================
+ Hits         6412     7211     +799     
+ Misses       3914     3784     -130     
- Partials      598      649      +51     
Flag Coverage Δ
e2e-test 39.09% <41.37%> (?)
e2e-test-runtime-go 30.29% <41.37%> (?)
e2e-test-runtime-python 30.23% <41.37%> (?)
e2e-test-runtime-quarkus 30.38% <41.37%> (?)
e2e-test-runtime-springboot 30.45% <41.37%> (?)
e2e-test-runtime-typescript 30.40% <41.37%> (?)
integration-tests 50.07% <89.65%> (+0.21%) ⬆️
unit-tests ?
unit-tests-macos-latest 48.77% <89.65%> (?)
unit-tests-ubuntu-latest 49.72% <89.65%> (?)
unit-tests-windows-latest 48.65% <89.65%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/run.go 73.85% <89.65%> (+3.22%) ⬆️

... and 46 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland added this to the Release 1.10 milestone Mar 14, 2023
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for adding

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, manoelmarques

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@knative-prow knative-prow bot merged commit 55f3d24 into knative:main Mar 14, 2023
@manoelmarques manoelmarques deleted the builder branch March 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include --builder option on func run command
2 participants