Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PAC - add support for S2I #1610

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

zroubalik
Copy link
Contributor

Changes

  • 🎁 PAC - add support for S2I

/kind enhancement

Relates: #1323

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2023
@knative-prow knative-prow bot requested review from maximilien and rhuss March 9, 2023 12:45
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 82.35% and project coverage change: +14.17 🎉

Comparison is base (e3b318a) 49.55% compared to head (cc3cc1d) 63.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1610       +/-   ##
===========================================
+ Coverage   49.55%   63.72%   +14.17%     
===========================================
  Files          80       92       +12     
  Lines       10754    11601      +847     
===========================================
+ Hits         5329     7393     +2064     
+ Misses       4962     3537     -1425     
- Partials      463      671      +208     
Flag Coverage Δ
e2e-test 39.08% <0.00%> (?)
e2e-test-oncluster 34.91% <0.00%> (?)
e2e-test-oncluster-runtime 29.60% <0.00%> (?)
e2e-test-runtime-go 30.31% <0.00%> (?)
e2e-test-runtime-python 30.25% <0.00%> (?)
e2e-test-runtime-quarkus 30.42% <0.00%> (?)
e2e-test-runtime-springboot 30.47% <0.00%> (?)
e2e-test-runtime-typescript 30.42% <0.00%> (?)
integration-tests 49.88% <82.35%> (?)
unit-tests ?
unit-tests-macos-latest 48.65% <82.35%> (?)
unit-tests-ubuntu-latest 49.60% <82.35%> (?)
unit-tests-windows-latest 48.53% <82.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipelines/tekton/templates.go 72.00% <82.35%> (+2.12%) ⬆️

... and 58 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b793f87 into knative:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants