Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support flags for func config git set command #1604

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Mar 8, 2023

Changes

  • 🎁 support flags for func config git set command

/kind enhancement

Relates: #1323

Adds support for Git-based deploy options to be configured using CLI flags

@knative-prow
Copy link

knative-prow bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 65.71% and project coverage change: +4.91 🎉

Comparison is base (b03ada6) 58.69% compared to head (9bc4140) 63.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   58.69%   63.61%   +4.91%     
==========================================
  Files          82       92      +10     
  Lines       10924    11644     +720     
==========================================
+ Hits         6412     7407     +995     
+ Misses       3914     3562     -352     
- Partials      598      675      +77     
Flag Coverage Δ
e2e-test 39.16% <65.71%> (?)
e2e-test-oncluster 34.82% <65.71%> (?)
e2e-test-runtime-go 30.36% <65.71%> (?)
e2e-test-runtime-python 30.32% <65.71%> (?)
e2e-test-runtime-quarkus 30.47% <65.71%> (?)
e2e-test-runtime-springboot 30.52% <65.71%> (?)
e2e-test-runtime-typescript 30.47% <65.71%> (?)
integration-tests 49.95% <65.71%> (+0.09%) ⬆️
unit-tests ?
unit-tests-macos-latest 48.72% <65.71%> (?)
unit-tests-ubuntu-latest 49.67% <65.71%> (?)
unit-tests-windows-latest 48.60% <65.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/config_git_set.go 28.27% <62.50%> (+8.76%) ⬆️
cmd/deploy.go 74.06% <100.00%> (+0.65%) ⬆️

... and 46 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/config_git_set.go Outdated Show resolved Hide resolved
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just a couple of wordsmithing comments

cmd/config_git_set.go Outdated Show resolved Hide resolved
cmd/config_git_set.go Outdated Show resolved Hide resolved
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@lance
Copy link
Member

lance commented Mar 13, 2023

/lgtm
Thanks @zroubalik 👍

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@knative-prow knative-prow bot merged commit ed1d963 into knative:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants