Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] feat: enabled s2i for python (#1562) #1579

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

lance
Copy link
Member

@lance lance commented Feb 21, 2023

This is a cherry pick of #1562 to enable s2i builds for Python in 1.9.x releases.

/cc @matejvasek

/kind enhancement

* feat: enable s2i for python

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2023
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 63.01% // Head: 60.82% // Decreases project coverage by -2.20% ⚠️

Coverage data is based on head (c746055) compared to base (5333945).
Patch has no changes to coverable lines.

❗ Current head c746055 differs from pull request most recent head ff0f592. Consider uploading reports for the commit ff0f592 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1579      +/-   ##
===============================================
- Coverage        63.01%   60.82%   -2.20%     
===============================================
  Files               74       74              
  Lines            10764    10070     -694     
===============================================
- Hits              6783     6125     -658     
+ Misses            3422     3388      -34     
+ Partials           559      557       -2     
Flag Coverage Δ
integration-tests 49.95% <ø> (-3.29%) ⬇️
unit-tests-macos-latest 49.98% <ø> (?)
unit-tests-ubuntu-latest 51.50% <ø> (?)
unit-tests-windows-latest 50.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
s2i/builder.go 61.33% <ø> (ø)
docker/zz_close_guarding_client_generated.go
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
knative/deployer.go 62.13% <0.00%> (+0.49%) ⬆️
client.go 62.57% <0.00%> (+0.61%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

* cleanup: style

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: use current func image for in cluster tests

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2023
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1dd4eb6 into knative:release-1.9 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants