-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: common command aliases #1578
feat: common command aliases #1578
Conversation
Ensures commands which have subcommands to operate on individual members (list, add, remove etc) have singular and plural as aliases. Ensures consistent usage of linux-command-style aliases for list,remove and rename operations: "ls", "rm", "mv"
Codecov ReportBase: 60.26% // Head: 60.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 60.26% 60.59% +0.32%
==========================================
Files 75 76 +1
Lines 10308 10318 +10
==========================================
+ Hits 6212 6252 +40
+ Misses 3524 3495 -29
+ Partials 572 571 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@lkingland sorry, I mistaken this PR with mine 😄 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
Nice improvement :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ensures commands which have subcommands to operate on individual members (list, add, remove etc) have singular and plural as aliases.
Ensures consistent usage of linux-command-style aliases for list,remove and rename operations: "ls", "rm", "mv"
/kind enhancement