Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common command aliases #1578

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

lkingland
Copy link
Member

  • 🎁 commands which refer to sets ignore plurality
  • 🎁 aliases added for linux command synonyms

Ensures commands which have subcommands to operate on individual members (list, add, remove etc) have singular and plural as aliases.

Ensures consistent usage of linux-command-style aliases for list,remove and rename operations: "ls", "rm", "mv"

/kind enhancement

Commands such as `envs` can be referred to by their singular form `env` and vice-versa.
Commands with well-known command synonyms were added as aliases, such as`labels delete <name>` now supports `labels rm <name>`

Ensures commands which have subcommands to operate on individual members
(list, add, remove etc) have singular and plural as aliases.

Ensures consistent usage of linux-command-style aliases for list,remove
and rename operations: "ls", "rm", "mv"
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2023
@lkingland lkingland changed the title command aliases feat: common command aliases Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 60.26% // Head: 60.59% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (07b7a28) compared to base (c20c887).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   60.26%   60.59%   +0.32%     
==========================================
  Files          75       76       +1     
  Lines       10308    10318      +10     
==========================================
+ Hits         6212     6252      +40     
+ Misses       3524     3495      -29     
+ Partials      572      571       -1     
Flag Coverage Δ
integration-tests 50.97% <100.00%> (+0.03%) ⬆️
unit-tests ?
unit-tests-macos-latest 49.48% <100.00%> (?)
unit-tests-ubuntu-latest 50.96% <100.00%> (?)
unit-tests-windows-latest 49.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/config_envs.go 25.79% <100.00%> (+0.39%) ⬆️
cmd/config_labels.go 73.30% <100.00%> (+0.26%) ⬆️
cmd/config_volumes.go 25.94% <100.00%> (+0.80%) ⬆️
cmd/repository.go 57.42% <100.00%> (+0.16%) ⬆️
pkg/knative/deployer.go 62.46% <0.00%> (-0.64%) ⬇️
pkg/docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
pkg/functions/client.go 59.21% <0.00%> (+0.55%) ⬆️
pkg/knative/logs.go 85.56% <0.00%> (+1.03%) ⬆️
pkg/docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
pkg/docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zroubalik zroubalik marked this pull request as ready for review February 21, 2023 11:37
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2023
@zroubalik zroubalik requested review from matejvasek and lance and removed request for navidshaikh and nainaz February 21, 2023 11:37
@zroubalik zroubalik marked this pull request as draft February 21, 2023 11:38
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2023
@zroubalik
Copy link
Contributor

@lkingland sorry, I mistaken this PR with mine 😄 🤦‍♂️

@lkingland lkingland marked this pull request as ready for review February 21, 2023 14:23
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2023
@lkingland lkingland requested review from zroubalik and removed request for vyasgun February 22, 2023 00:22
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel
Nice improvement :)

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance,lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3624ccb into knative:main Feb 23, 2023
@lkingland lkingland deleted the command-plurality-aliases branch March 5, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants