Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testData -> testdata #1560

Merged
merged 1 commit into from
Feb 16, 2023
Merged

chore: testData -> testdata #1560

merged 1 commit into from
Feb 16, 2023

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Feb 16, 2023

Changes

Some test related folders are named as testdata and others as testData (with camel case), unifying this under testdata

./cmd/testdata
./pkg/builders/s2i/testData
./pkg/config/testdata
./pkg/docker/testData
./pkg/functions/testdata
./pkg/k8s/testData
./pkg/knative/testdata
./pkg/pipelines/tekton/testData
  • 🧹 unifying test data directories as testdata

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 60.27% // Head: 60.49% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (21f952e) compared to base (ec6c698).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   60.27%   60.49%   +0.22%     
==========================================
  Files          75       76       +1     
  Lines       10237    10239       +2     
==========================================
+ Hits         6170     6194      +24     
+ Misses       3497     3474      -23     
- Partials      570      571       +1     
Flag Coverage Δ
integration-tests 50.87% <ø> (-0.02%) ⬇️
unit-tests ?
unit-tests-macos-latest 49.38% <ø> (?)
unit-tests-ubuntu-latest 50.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/knative/logs.go 80.41% <0.00%> (-4.13%) ⬇️
pkg/docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
pkg/docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b26a1c2 into knative:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants