Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add tekton artifacts to release #1557

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

lance
Copy link
Member

@lance lance commented Feb 15, 2023

Changes

Adds the Tekton tasks for buildpacks, s2i and deployment to the release artifacts.

Note that the checksums.txt file will contain references to the full path of the files. I don't think this is a problem, but something to be look out for in case there is an issue.

/kind chore

Release Note

Adds Tekton Tasks to release artifacts.

Fixes: #1550
Related: #1333

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added kind/chore size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2023
@knative-prow knative-prow bot requested review from nainaz and rhuss February 15, 2023 15:51
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 60.28% // Head: 60.54% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (bd30d4d) compared to base (5a4803b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   60.28%   60.54%   +0.26%     
==========================================
  Files          75       76       +1     
  Lines       10214    10216       +2     
==========================================
+ Hits         6157     6185      +28     
+ Misses       3489     3462      -27     
- Partials      568      569       +1     
Flag Coverage Δ
integration-tests 50.89% <ø> (ø)
unit-tests ?
unit-tests-macos-latest 49.37% <ø> (?)
unit-tests-ubuntu-latest 50.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
pkg/docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lance lance changed the title chore: add tekton artifacts to release chore(release): add tekton artifacts to release Feb 15, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4e8ef49 into knative:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tekton pipeline resources should be included in release
2 participants