-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): remove liveness and readiness from defaults #1555
Conversation
Codecov ReportBase: 60.28% // Head: 50.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 60.28% 50.85% -9.43%
==========================================
Files 75 73 -2
Lines 10214 10079 -135
==========================================
- Hits 6157 5126 -1031
- Misses 3489 4519 +1030
+ Partials 568 434 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/hold |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it passes tests, this is precisely what I was hoping would work!
/lgtm
/hold for zbynek's massive refactor to the repo to land first, which was submitted one hour prior
The liveness and readiness URLs are defined in code as defaulting to `/health/liveness` and `/health/readiness` respectively. The deploy command handles these defaults without requiring them to exist in the `func.yaml` file. Existing tests for defaults and overrides already exist, so this change does not require additional tests to be included. Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
244c629
to
87cf62c
Compare
@lkingland after rebasing, I need another /lgtm please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override codecov/project |
@zroubalik: Overrode contexts on behalf of zroubalik: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
The liveness and readiness URLs are defined in code as defaulting to
/health/liveness
and/health/readiness
respectively. The deploy command handles these defaults without requiring them to exist in thefunc.yaml
file. Existing tests for defaults and overrides already exist, so this change does not require additional tests to be included./kind enhancement
Fixes: #1281
Release Note