-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow trailing path flag #1519
fix: allow trailing path flag #1519
Conversation
Codecov ReportBase: 63.05% // Head: 63.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 63.05% 63.34% +0.29%
==========================================
Files 74 75 +1
Lines 10768 10766 -2
==========================================
+ Hits 6790 6820 +30
+ Misses 3420 3390 -30
+ Partials 558 556 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.8 |
@lance: #1519 failed to apply on top of branch "release-1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Updates the early-stage
effectivePath
method, which directly evaluates--path
to use thepflag
library, which implements a more permissive model for parsing flags (POSIX/GNU-style), including the ability to define a flag trailing subcommands, and is the library used by the command structs internally./kind bug
Release Note