Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: envvar parsing for pack tekton task #1512

Merged

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🐛 Fix envvar parsing for pack tekton task when envvar contains the = char

/kind bug

fix: envvar parsing for pack tekton task when envvar contains the `=` char

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 20, 2023
@matejvasek matejvasek requested review from lance and removed request for maximilien and dsimansk January 20, 2023 16:55
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 63.05% // Head: 63.37% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (babe6a6) compared to base (f77971b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   63.05%   63.37%   +0.31%     
==========================================
  Files          74       75       +1     
  Lines       10768    10770       +2     
==========================================
+ Hits         6790     6825      +35     
+ Misses       3420     3388      -32     
+ Partials      558      557       -1     
Flag Coverage Δ
integration-tests 53.25% <ø> (-0.03%) ⬇️
unit-tests ?
unit-tests-macos-latest 53.29% <ø> (?)
unit-tests-ubuntu-latest 54.69% <ø> (?)
unit-tests-windows-latest 53.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
knative/deployer.go 61.47% <0.00%> (ø)
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 62.57% <0.00%> (+0.61%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

good catch

@knative-prow
Copy link

knative-prow bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 2c3cca0 into knative:main Jan 20, 2023
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants