-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: envvar parsing for pack tekton task #1512
fix: envvar parsing for pack tekton task #1512
Conversation
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Codecov ReportBase: 63.05% // Head: 63.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
==========================================
+ Coverage 63.05% 63.37% +0.31%
==========================================
Files 74 75 +1
Lines 10768 10770 +2
==========================================
+ Hits 6790 6825 +35
+ Misses 3420 3388 -32
+ Partials 558 557 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
good catch
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matej Vasek <mvasek@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com>
Changes
=
char/kind bug