-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message for missing registry name #1510
Conversation
When a user attempts to build, run or deploy a function and it has not been previously built, the `--registry` flag or `FUNC_REGISTRY` environment variable must be set so that the image name can be calculated. The current error message, `registry required` is not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the `--registry` flag or `FUNC_REGISTRY` environment variable. Fixes: knative#1504 Signed-off-by: Lance Ball <lball@redhat.com>
Codecov ReportBase: 54.90% // Head: 63.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 54.90% 63.32% +8.42%
==========================================
Files 72 75 +3
Lines 10597 10770 +173
==========================================
+ Hits 5818 6820 +1002
+ Misses 4352 3394 -958
- Partials 427 556 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When a user attempts to build, run or deploy a function and it has not been previously built, the `--registry` flag or `FUNC_REGISTRY` environment variable must be set so that the image name can be calculated. The current error message, `registry required` is not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the `--registry` flag or `FUNC_REGISTRY` environment variable. Fixes: knative#1504 Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Lance Ball <lball@redhat.com>
When a user attempts to build, run or deploy a function and it has not been previously built, the
--registry
flag orFUNC_REGISTRY
environment variable must be set so that the image name can be calculated. The current error message,registry required
is not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the--registry
flag orFUNC_REGISTRY
environment variable.New behavior (https://app.warp.dev/block/YhpjkGod6HI8r2FbaBTeWz):
Fixes: #1504
Signed-off-by: Lance Ball lball@redhat.com
/kind enhancement