fix: improve error message for missing registry name #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user attempts to build, run or deploy a function and it has not been previously built, the `--registry` flag or `FUNC_REGISTRY` environment variable must be set so that the image name can be calculated. The current error message, `registry required` is not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the `--registry` flag or `FUNC_REGISTRY` environment variable. Fixes: knative#1504 Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow
bot
added
approved
Codecov ReportBase: 54.90% // Head: 63.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 54.90% 63.32% +8.42%
==========================================
Files 72 75 +3
Lines 10597 10770 +173
==========================================
+ Hits 5818 6820 +1002
+ Misses 4352 3394 -958
- Partials 427 556 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lance
added a commit
to lance/func
that referenced
this pull request
Feb 15, 2023
When a user attempts to build, run or deploy a function and it has not been previously built, the `--registry` flag or `FUNC_REGISTRY` environment variable must be set so that the image name can be calculated. The current error message, `registry required` is not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the `--registry` flag or `FUNC_REGISTRY` environment variable. Fixes: knative#1504 Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user attempts to build, run or deploy a function and it has not been previously built, the
--registryflag orFUNC_REGISTRYenvironment variable must be set so that the image name can be calculated. The current error message,registry requiredis not very helpful, and requires the user to divine what needs to happen next to fix the problem. This change updates the error message text to indicate that the user should set the--registryflag orFUNC_REGISTRYenvironment variable.New behavior (https://app.warp.dev/block/YhpjkGod6HI8r2FbaBTeWz):
Fixes: #1504
Signed-off-by: Lance Ball lball@redhat.com
/kind enhancement