Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update springboot templates to Spring Boot 3.0 #1509

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Update springboot templates to Spring Boot 3.0 #1509

merged 1 commit into from
Jan 24, 2023

Conversation

trisberg
Copy link
Member

  • add needed buildEnv properties
  • add class to register runtime hints for MessageUtils.MessageStructureWithCaseInsensitiveHeaderKeys
  • update README files

Signed-off-by: Thomas Risberg trisberg@pivotal.io

Changes

  • 🧹 Update springboot templates for Spring Boot 3.0
  • 🐛 This fixes build issues that will happen after anonymous access to repo.spring.io/release is turned off Jan 26, 2023

/kind enhancement

Fixes #1470

Release Note


The springboot templates have been updated to use Spring Boot 3.0 and the new Spring 6.0 AOT support. Note: this requires Java 17 when building locally.

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Jan 19, 2023
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited

Codecov Report

Base: 63.02% // Head: 63.37% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (ac61f77) compared to base (2c3cca0).
Patch has no changes to coverable lines.

❗ Current head ac61f77 differs from pull request most recent head b2364b3. Consider uploading reports for the commit b2364b3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   63.02%   63.37%   +0.34%     
==========================================
  Files          74       75       +1     
  Lines       10768    10770       +2     
==========================================
+ Hits         6787     6825      +38     
+ Misses       3423     3388      -35     
+ Partials      558      557       -1
Flag Coverage Δ
integration-tests 53.25% <ø> (ø)
unit-tests ?
unit-tests-macos-latest 53.29% <ø> (?)
unit-tests-ubuntu-latest 54.69% <ø> (?)
unit-tests-windows-latest 53.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
knative/logs.go 80.41% <0.00%> (-2.07%) ⬇️
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 62.57% <0.00%> (+0.61%) ⬆️
knative/deployer.go 62.13% <0.00%> (+0.81%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trisberg trisberg force-pushed the springboot-3.0 branch 2 times, most recently from 832cd2c to e407742 Compare January 19, 2023 21:23
@lkingland lkingland mentioned this pull request Jan 20, 2023
Merged
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2023
@trisberg trisberg marked this pull request as ready for review January 20, 2023 18:29
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@trisberg
Update springboot templates to Spring Boot 3.0.2
b2364b3 
- add needed buildEnv properties
- add class to register runtime hints for MessageUtils.MessageStructureWithCaseInsensitiveHeaderKeys
- update README files
- update unit tests to use Java 17

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>
@lkingland
Copy link
Member

The only E2E test to fail was the OnCluster TestRuntime/node_s2i_test, which failed with:

Error: failed to run pipeline: function pipeline run has failed with message: 
...
error creating build container: copying system image from manifest list: writing blob: storing blob to file "/var/tmp/storage2885866326/3": happened during read: unexpected EOF

This seems transient to me so I'll re-run the failed tests now.

@trisberg
Copy link
Member Author

/cc @salaboy

@knative-prow knative-prow bot requested a review from salaboy January 23, 2023 15:19
@lance lance added this to the 1.9.0 Release milestone Jan 24, 2023
@lance
Copy link
Member

lance commented Jan 24, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, trisberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2023
@knative-prow knative-prow bot merged commit d090d5d into knative:main Jan 24, 2023
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@trisberg @lance
Update springboot templates to Spring Boot 3.0.2 (knative#1509)
05eb222 
- add needed buildEnv properties
- add class to register runtime hints for MessageUtils.MessageStructureWithCaseInsensitiveHeaderKeys
- update README files
- update unit tests to use Java 17

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@maximilien maximilien Awaiting requested review from maximilien

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

@salaboy salaboy Awaiting requested review from salaboy

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Functions WG Roadmap
Archived in project
Milestone
1.9.0 Release
Development

Successfully merging this pull request may close these issues.

Upgrade Spring Boot to 3.0
4 participants
@trisberg @lkingland @lance @knative-prow-robot