Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deploy with autoscaling options specified #1482

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: deploy with autoscaling options specified #1482

merged 1 commit into from
Jan 6, 2023

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jan 4, 2023 •
edited by lance

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Changes

  • 🐛 fix deploy with autoscaling options specified

/kind bug

Fixes #1481

Release Notes

Fixes a bug preventing autoscaling options from being applied

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@zroubalik zroubalik changed the title fix: deploy with options specified fix: deploy with autoscaling options specified Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023 •
edited

Codecov Report

Base: 63.12% // Head: 63.42% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (920ad9e) compared to base (fd982c1).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   63.12%   63.42%   +0.29%     
==========================================
  Files          74       75       +1     
  Lines       10802    10808       +6     
==========================================
+ Hits         6819     6855      +36     
+ Misses       3426     3396      -30     
  Partials      557      557
Flag Coverage Δ
integration-tests 53.37% <40.00%> (+0.20%) ⬆️
unit-tests ?
unit-tests-macos-latest 53.42% <0.00%> (?)
unit-tests-ubuntu-latest 54.79% <0.00%> (?)
unit-tests-windows-latest 53.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
knative/deployer.go 61.47% <40.00%> (-0.25%) ⬇️
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 62.57% <0.00%> (+0.61%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zroubalik
fix: deploy with options specified
920ad9e 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
lance
lance reviewed Jan 6, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@knative-prow knative-prow bot merged commit c1b4741 into knative:main Jan 6, 2023
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@zroubalik @lance
fix: deploy with options specified (knative#1482)
d00575c 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@vyasgun vyasgun Awaiting requested review from vyasgun

@matejvasek matejvasek Awaiting requested review from matejvasek

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to specify autoscaling options
2 participants
@zroubalik @lance