Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update image tag in tekton pipeline #1340

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

lance
Copy link
Member

@lance lance commented Oct 14, 2022

Changes

  • 🧹 reference the func image at ghcr.io/knative/func:latest in tekton pipelines

We are now producing func images in the knative org.

Signed-off-by: Lance Ball lball@redhat.com

/kind chore

Release Note

Uses `func` image from `ghcr.io/knative/func:latest` in tekton on-cluster build pipeline

We are now producing `func` images in the knative org.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 59.77% // Head: 60.12% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (40826f9) compared to base (8ac4941).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   59.77%   60.12%   +0.34%     
==========================================
  Files          73       74       +1     
  Lines       10440    10442       +2     
==========================================
+ Hits         6241     6278      +37     
+ Misses       3681     3646      -35     
  Partials      518      518              
Flag Coverage Δ
integration-tests 52.37% <ø> (+0.05%) ⬆️
unit-tests ?
unit-tests-macos-latest 52.88% <ø> (?)
unit-tests-ubuntu-latest 54.30% <ø> (?)
unit-tests-windows-latest 52.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 65.18% <0.00%> (+0.60%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
knative/logs.go 80.24% <0.00%> (+2.46%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@knative-prow knative-prow bot merged commit 47d5082 into knative:main Oct 14, 2022
lance added a commit to lance/func that referenced this pull request Feb 15, 2023
We are now producing `func` images in the knative org.

Signed-off-by: Lance Ball <lball@redhat.com>

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants