Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel pipeline run on SIGINT/SIGTERM #1329

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Oct 13, 2022

Changes

  • 🎁 Cancel pipeline run on SIGINT/SIGTERM (without this func deploy --remove was uncancellable).

/kind enhancement

feat: cancel pipeline run on SIGINT/SIGTERM

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2022
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@matejvasek matejvasek requested a review from lance October 13, 2022 16:17
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @zroubalik

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 49.13% // Head: 49.38% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (df24b62) compared to base (4961298).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
+ Coverage   49.13%   49.38%   +0.25%     
==========================================
  Files          76       77       +1     
  Lines       10539    10555      +16     
==========================================
+ Hits         5178     5213      +35     
+ Misses       4918     4900      -18     
+ Partials      443      442       -1     
Flag Coverage Δ
integration-tests 43.96% <ø> (-0.04%) ⬇️
unit-tests ?
unit-tests-macos-latest 46.06% <0.00%> (?)
unit-tests-ubuntu-latest 47.50% <0.00%> (?)
unit-tests-windows-latest 46.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pipelines/tekton/pipeplines_provider.go 0.00% <0.00%> (ø)
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 65.18% <0.00%> (+0.60%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
docker/docker_client.go 83.19% <0.00%> (+23.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zroubalik
Copy link
Contributor

/override codecov/patch

@knative-prow
Copy link

knative-prow bot commented Oct 14, 2022

@zroubalik: Overrode contexts on behalf of zroubalik: codecov/patch

In response to this:

/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit dce1e75 into knative:main Oct 14, 2022
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants