-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cancel pipeline run on SIGINT/SIGTERM #1329
feat: cancel pipeline run on SIGINT/SIGTERM #1329
Conversation
Signed-off-by: Matej Vasek <mvasek@redhat.com>
45080ee
to
df24b62
Compare
PTAL @zroubalik |
Codecov ReportBase: 49.13% // Head: 49.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
+ Coverage 49.13% 49.38% +0.25%
==========================================
Files 76 77 +1
Lines 10539 10555 +16
==========================================
+ Hits 5178 5213 +35
+ Misses 4918 4900 -18
+ Partials 443 442 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override codecov/patch |
@zroubalik: Overrode contexts on behalf of zroubalik: codecov/patch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matej Vasek <mvasek@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com>
Changes
SIGINT
/SIGTERM
(without thisfunc deploy --remove
was uncancellable)./kind enhancement