chore: update all references to kn-plugin-func #1311

lance · 2022-10-10T17:38:23Z

Changes

🧹 update all references to "kn-plugin-func", changing them to "func"

I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc.

Signed-off-by: Lance Ball lball@redhat.com

/kind chore

changes package name from knative.dev/kn-plugin-func to knative.dev/func

codecov · 2022-10-10T17:51:25Z

Codecov Report

Base: 47.59% // Head: 49.45% // Increases project coverage by +1.85% 🎉

Coverage data is based on head (1e99191) compared to base (9536e33).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   47.59%   49.45%   +1.85%     
==========================================
  Files          74       77       +3     
  Lines       10415    10541     +126     
==========================================
+ Hits         4957     5213     +256     
+ Misses       5036     4886     -150     
- Partials      422      442      +20

Flag	Coverage Δ
integration-tests	`43.96% <100.00%> (?)`
unit-tests-macos-latest	`46.09% <100.00%> (?)`
unit-tests-ubuntu-latest	`47.59% <100.00%> (?)`
unit-tests-windows-latest	`46.14% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
builders/builders.go	`84.21% <ø> (ø)`
buildpacks/builder.go	`39.09% <ø> (ø)`
client.go	`65.18% <ø> (+0.60%)`	⬆️
cmd/build.go	`64.22% <ø> (ø)`
cmd/client.go	`78.82% <ø> (ø)`
cmd/completion_util.go	`0.00% <ø> (ø)`
cmd/config.go	`30.27% <ø> (ø)`
cmd/config_envs.go	`25.32% <ø> (ø)`
cmd/config_labels.go	`70.45% <ø> (ø)`
cmd/config_volumes.go	`25.64% <ø> (ø)`
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lance · 2022-10-10T19:24:37Z

Base: 47.20% // Head: 49.10% // Increases project coverage by +1.89% 🎉

Hilarious

lance · 2022-10-12T00:56:48Z

@dsimansk this verify failure I believe is from hack/update-codegen.sh on a mac :/

lkingland

Looking great!
Two minor comments inline.

Regarding the failing Verify action:

As you know the Knative dependency management tooling uses go-licenses which seems to give slightly different results on different OSs. This is the root cause of the verify CI task failure. When checked in the CI environment, the changes to the third_party directory in this PR are not present when it does its self-check.
Therefore, until we can isolate the underlying cause and either fix our usage of golicenses to be non-os-depenent, or submit a patch, the quick way to fix the error for our purposes is to remove the folloiwing changes to the third_party directory:

removal of third_party/VENDOR-LICENSE/github.com/moby/sys/mount/LICENSE
rename of third_party/VENDOR-LICENSE/github.com/opencontainers/selinux/go-selinux)/LICENSE
rename of third_party/VENDOR-LICENSE/knative.dev/func/LICENSE
If that doesn't do the trick, I have a small GitHub action I use temporarily to get some better log statements from that action to show the exact conflicts reported.

cmd/root.go

docs/reference/func_create.md

dsimansk · 2022-10-12T10:17:03Z

@lance to fix verify (licenses) you can also try:

 GOOS=linux go-licenses save "./..." --save_path="third_party/VENDOR-LICENSE" --force

v1.2.1 is used in the tooling: go install github.com/google/go-licenses@v1.2.1

lkingland · 2022-10-12T11:55:00Z

cause and either fix our usage of golicenses to be non-os-depenent,

Perhaps we should patch the Knative script which invokes go-licenses to include GOOS=linux such that others using non-linux OSs do not encounter the same problem.

zroubalik

/lgtm

/hold for others

knative-prow · 2022-10-12T14:27:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lance,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc. Signed-off-by: Lance Ball <lball@redhat.com>

Signed-off-by: Lance Ball <lball@redhat.com>

lance · 2022-10-13T12:57:54Z

@lkingland @matejvasek @zroubalik ptal again 🙇

README.md

Signed-off-by: Lance Ball <lball@redhat.com>

salaboy · 2022-10-13T15:55:16Z

/lgtm

matejvasek · 2022-10-13T16:31:20Z

/unhold

matejvasek · 2022-10-13T16:31:33Z

/lgtm

* chore: update all references to kn-plugin-func I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc. Signed-off-by: Lance Ball <lball@redhat.com> * fixup: fix instances_test.go Signed-off-by: Lance Ball <lball@redhat.com> * fixup: still some stray kn-plugin-func Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Lance Ball <lball@redhat.com>

knative-prow bot added kind/chore size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2022

lance added this to the 1.8.0 Release milestone Oct 10, 2022

lance requested review from lkingland and matejvasek October 10, 2022 17:42

lkingland reviewed Oct 12, 2022

View reviewed changes

cmd/root.go Outdated Show resolved Hide resolved

docs/reference/func_create.md Outdated Show resolved Hide resolved

zroubalik approved these changes Oct 12, 2022

View reviewed changes

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022

knative-prow bot assigned zroubalik Oct 12, 2022

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022

chore: update all references to kn-plugin-func

ecb0e76

I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc. Signed-off-by: Lance Ball <lball@redhat.com>

lance force-pushed the change-kn-plugin-func-to-func branch from bcee31e to ecb0e76 Compare October 12, 2022 19:56

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022

fixup: fix instances_test.go

8550c9a

Signed-off-by: Lance Ball <lball@redhat.com>

zroubalik reviewed Oct 13, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

fixup: still some stray kn-plugin-func

1e99191

Signed-off-by: Lance Ball <lball@redhat.com>

knative-prow bot assigned salaboy Oct 13, 2022

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2022

knative-prow bot assigned matejvasek Oct 13, 2022

knative-prow bot merged commit 5adec03 into knative:main Oct 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update all references to kn-plugin-func #1311

chore: update all references to kn-plugin-func #1311

lance commented Oct 10, 2022

codecov bot commented Oct 10, 2022 •

edited

Loading

lance commented Oct 10, 2022

lance commented Oct 12, 2022

lkingland left a comment •

edited

Loading

dsimansk commented Oct 12, 2022

lkingland commented Oct 12, 2022

zroubalik left a comment

knative-prow bot commented Oct 12, 2022

lance commented Oct 13, 2022

salaboy commented Oct 13, 2022

matejvasek commented Oct 13, 2022

matejvasek commented Oct 13, 2022

chore: update all references to kn-plugin-func #1311

chore: update all references to kn-plugin-func #1311

Conversation

lance commented Oct 10, 2022

Changes

codecov bot commented Oct 10, 2022 • edited Loading

Codecov Report

lance commented Oct 10, 2022

lance commented Oct 12, 2022

lkingland left a comment • edited Loading

Choose a reason for hiding this comment

dsimansk commented Oct 12, 2022

lkingland commented Oct 12, 2022

zroubalik left a comment

Choose a reason for hiding this comment

knative-prow bot commented Oct 12, 2022

lance commented Oct 13, 2022

salaboy commented Oct 13, 2022

matejvasek commented Oct 13, 2022

matejvasek commented Oct 13, 2022

codecov bot commented Oct 10, 2022 •

edited

Loading

lkingland left a comment •

edited

Loading