-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update all references to kn-plugin-func #1311
chore: update all references to kn-plugin-func #1311
Conversation
Codecov ReportBase: 47.59% // Head: 49.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 47.59% 49.45% +1.85%
==========================================
Files 74 77 +3
Lines 10415 10541 +126
==========================================
+ Hits 4957 5213 +256
+ Misses 5036 4886 -150
- Partials 422 442 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hilarious |
@dsimansk this verify failure I believe is from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Two minor comments inline.
Regarding the failing Verify
action:
As you know the Knative dependency management tooling uses go-licenses
which seems to give slightly different results on different OSs. This is the root cause of the verify
CI task failure. When checked in the CI environment, the changes to the third_party
directory in this PR are not present when it does its self-check.
Therefore, until we can isolate the underlying cause and either fix our usage of golicenses to be non-os-depenent, or submit a patch, the quick way to fix the error for our purposes is to remove the folloiwing changes to the third_party
directory:
- removal of
third_party/VENDOR-LICENSE/github.com/moby/sys/mount/LICENSE
- rename of
third_party/VENDOR-LICENSE/github.com/opencontainers/selinux/go-selinux)/LICENSE
- rename of
third_party/VENDOR-LICENSE/knative.dev/func/LICENSE
If that doesn't do the trick, I have a small GitHub action I use temporarily to get some better log statements from that action to show the exact conflicts reported.
@lance to fix verify (licenses) you can also try:
v1.2.1 is used in the tooling: |
Perhaps we should patch the Knative script which invokes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for others
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc. Signed-off-by: Lance Ball <lball@redhat.com>
bcee31e
to
ecb0e76
Compare
Signed-off-by: Lance Ball <lball@redhat.com>
@lkingland @matejvasek @zroubalik ptal again 🙇 |
Signed-off-by: Lance Ball <lball@redhat.com>
/lgtm |
/unhold |
/lgtm |
* chore: update all references to kn-plugin-func I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc. Signed-off-by: Lance Ball <lball@redhat.com> * fixup: fix instances_test.go Signed-off-by: Lance Ball <lball@redhat.com> * fixup: still some stray kn-plugin-func Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Lance Ball <lball@redhat.com>
Changes
I did not change references in CHANGELOG.md but otherwise, I believe this should cover all configuration settings, image names, package names, etc.
Signed-off-by: Lance Ball lball@redhat.com
/kind chore