On cluster build without VCS #1298

matejvasek · 2022-10-04T22:28:40Z

Changes

🎁 Added function for upload to a volume. This might be useful for on cluster build without VCS.
🎁 Added On Cluster Build without VCS (e.g. Git).

/kind enhancement

feat: on cluster build using direct source upload (i.e. git is not needed)

Known issue: Direct upload in not working on OpenShift under privileged account.

resolves #952

codecov · 2022-10-04T22:38:46Z

Codecov Report

Merging #1298 (b76f286) into main (69659e3) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
- Coverage   47.06%   46.46%   -0.61%     
==========================================
  Files          73       73              
  Lines       10338    10473     +135     
==========================================
  Hits         4866     4866              
- Misses       5049     5184     +135     
  Partials      423      423

Impacted Files	Coverage Δ
k8s/dialer.go	`0.00% <0.00%> (ø)`
k8s/persistent_volumes.go	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matejvasek · 2022-10-06T00:19:04Z

@lkingland @lance PTAL

lance · 2022-10-08T18:27:14Z

/easycla

codecov · 2022-10-10T13:26:49Z

Codecov Report

Base: 59.80% // Head: 60.48% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (46495ba) compared to base (c740b11).
Patch coverage: 72.45% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   59.80%   60.48%   +0.67%     
==========================================
  Files          73       75       +2     
  Lines       10440    10639     +199     
==========================================
+ Hits         6244     6435     +191     
+ Misses       3679     3666      -13     
- Partials      517      538      +21

Flag	Coverage Δ
integration-tests	`49.99% <63.98%> (-2.40%)`	⬇️
unit-tests	`?`
unit-tests-macos-latest	`52.22% <20.33%> (?)`
unit-tests-ubuntu-latest	`53.64% <20.33%> (?)`
unit-tests-windows-latest	`52.21% <20.33%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/deploy.go	`62.38% <ø> (-0.07%)`	⬇️
pipelines/tekton/pipeplines_provider.go	`10.29% <48.27%> (+10.29%)`	⬆️
k8s/persistent_volumes.go	`72.22% <76.37%> (+72.22%)`	⬆️
pipelines/tekton/resources.go	`41.82% <84.21%> (+1.72%)`	⬆️
k8s/dialer.go	`72.58% <89.47%> (-1.48%)`	⬇️
k8s/security_context.go	`100.00% <100.00%> (ø)`
pipelines/tekton/tasks.go	`100.00% <100.00%> (ø)`
docker/docker_client_nonlinux.go	`0.00% <0.00%> (ø)`
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

matejvasek · 2022-10-10T13:37:26Z

@zroubalik PTAL

matejvasek · 2022-10-10T21:30:50Z

@salaboy PTAL

matejvasek · 2022-10-11T19:48:13Z

@jrangelramos PTAL

jrangelramos · 2022-10-11T19:48:45Z

I think a nice to have would be perform a check for .gitignore file on local function source code, and possibly honor that during upload. I would be concerned uploading for example build artifacts from a quarkus func for example (target folder).

matejvasek · 2022-10-11T20:02:27Z

I tested this on KinD and OpenShift 4.11 clusters.

On OpenShift 4.11+ it for now only works with non-admin users, because of the seccompprofile thingy.
Will need to apply fix in midstream.

lkingland

This is great!

Added @jrangelramos ' suggestion to evaluate .gitignore as #1298

/lgtm
/hold for optional, very minor suggestions inline

k8s/persistent_volumes.go

k8s/persistent_volumes_test.go

matejvasek · 2022-10-17T08:50:27Z

@lkingland I added e2e test, please re-lgtm.

matejvasek · 2022-10-17T08:50:39Z

@zroubalik @lance PTAL

lkingland · 2022-10-17T10:14:53Z

/lgtm
(still holding pending others' potential commentary)

hack/binaries.sh

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Co-authored-by: Lance Ball <lball@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek · 2022-10-17T12:08:47Z

I did a rebase.

zroubalik

/lgtm

great work!

knative-prow · 2022-10-17T13:59:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lkingland,matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

matejvasek · 2022-10-17T14:18:02Z

I think we are good to go @lance .

jrangelramos · 2022-10-17T16:47:53Z

/lgtm

lance · 2022-10-17T19:51:10Z

/unhold

* refactor: attach() and podReady() more general Signed-off-by: Matej Vasek <mvasek@redhat.com> * feat: added function for upload to a volume Signed-off-by: Matej Vasek <mvasek@redhat.com> * refactor: extract defaultSecurityContext Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: added runtime type check Signed-off-by: Matej Vasek <mvasek@redhat.com> * feat: allow on-cluster-build without VCS Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: reword error message Co-authored-by: Lance Ball <lball@redhat.com> * fix: runtime type check Signed-off-by: Matej Vasek <mvasek@redhat.com> * test: e2e test for direct upload on-cluster-build Signed-off-by: Matej Vasek <mvasek@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com> Co-authored-by: Lance Ball <lball@redhat.com>

matejvasek requested review from lkingland, jrangelramos, lance and zroubalik October 4, 2022 22:30

matejvasek force-pushed the cluster-build-no-git branch 3 times, most recently from 4d56d8e to 5493684 Compare October 5, 2022 23:45

matejvasek marked this pull request as ready for review October 6, 2022 00:18

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022

matejvasek force-pushed the cluster-build-no-git branch from 5493684 to 8386b67 Compare October 10, 2022 13:21

matejvasek force-pushed the cluster-build-no-git branch from 10edecb to 2510730 Compare October 11, 2022 19:01

matejvasek changed the title ~~Upload to a volume~~ On cluster build without VCS Oct 11, 2022

matejvasek force-pushed the cluster-build-no-git branch 3 times, most recently from 6524cda to 2425081 Compare October 11, 2022 19:18

lkingland approved these changes Oct 12, 2022

View reviewed changes

k8s/persistent_volumes.go Outdated Show resolved Hide resolved

k8s/persistent_volumes.go Outdated Show resolved Hide resolved

k8s/persistent_volumes_test.go Show resolved Hide resolved

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022

knative-prow bot assigned lkingland Oct 12, 2022

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022

matejvasek commented Oct 17, 2022

View reviewed changes

hack/binaries.sh Outdated Show resolved Hide resolved

matejvasek and others added 7 commits October 17, 2022 14:02

refactor: attach() and podReady() more general

8ca73ba

Signed-off-by: Matej Vasek <mvasek@redhat.com>

feat: added function for upload to a volume

4d71f4a

Signed-off-by: Matej Vasek <mvasek@redhat.com>

refactor: extract defaultSecurityContext

01c37db

Signed-off-by: Matej Vasek <mvasek@redhat.com>

fix: added runtime type check

84dc4dc

Signed-off-by: Matej Vasek <mvasek@redhat.com>

feat: allow on-cluster-build without VCS

d356237

Signed-off-by: Matej Vasek <mvasek@redhat.com>

fix: reword error message

af348aa

Co-authored-by: Lance Ball <lball@redhat.com>

fix: runtime type check

fea375f

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek force-pushed the cluster-build-no-git branch from 6bd863a to d61b6b7 Compare October 17, 2022 12:03

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022

test: e2e test for direct upload on-cluster-build

46495ba

Signed-off-by: Matej Vasek <mvasek@redhat.com>

matejvasek force-pushed the cluster-build-no-git branch from d61b6b7 to 46495ba Compare October 17, 2022 12:06

zroubalik approved these changes Oct 17, 2022

View reviewed changes

knative-prow bot assigned zroubalik Oct 17, 2022

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022

knative-prow bot assigned jrangelramos Oct 17, 2022

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022

knative-prow bot merged commit d536b79 into knative:main Oct 17, 2022

lance modified the milestones: 1.9.0 Release, 1.8.0 Release Oct 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On cluster build without VCS #1298

On cluster build without VCS #1298

matejvasek commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 4, 2022 •

edited

Loading

matejvasek commented Oct 6, 2022

lance commented Oct 8, 2022

codecov bot commented Oct 10, 2022 •

edited

Loading

matejvasek commented Oct 10, 2022

matejvasek commented Oct 10, 2022

matejvasek commented Oct 11, 2022

jrangelramos commented Oct 11, 2022 •

edited

Loading

matejvasek commented Oct 11, 2022

lkingland left a comment

matejvasek commented Oct 17, 2022

matejvasek commented Oct 17, 2022

lkingland commented Oct 17, 2022 •

edited

Loading

matejvasek commented Oct 17, 2022

zroubalik left a comment

knative-prow bot commented Oct 17, 2022

matejvasek commented Oct 17, 2022

jrangelramos commented Oct 17, 2022

lance commented Oct 17, 2022

On cluster build without VCS #1298

On cluster build without VCS #1298

Conversation

matejvasek commented Oct 4, 2022 • edited Loading

Changes

codecov bot commented Oct 4, 2022 • edited Loading

Codecov Report

matejvasek commented Oct 6, 2022

lance commented Oct 8, 2022

codecov bot commented Oct 10, 2022 • edited Loading

Codecov Report

matejvasek commented Oct 10, 2022

matejvasek commented Oct 10, 2022

matejvasek commented Oct 11, 2022

jrangelramos commented Oct 11, 2022 • edited Loading

matejvasek commented Oct 11, 2022

lkingland left a comment

Choose a reason for hiding this comment

matejvasek commented Oct 17, 2022

matejvasek commented Oct 17, 2022

lkingland commented Oct 17, 2022 • edited Loading

matejvasek commented Oct 17, 2022

zroubalik left a comment

Choose a reason for hiding this comment

knative-prow bot commented Oct 17, 2022

matejvasek commented Oct 17, 2022

jrangelramos commented Oct 17, 2022

lance commented Oct 17, 2022

matejvasek commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 10, 2022 •

edited

Loading

jrangelramos commented Oct 11, 2022 •

edited

Loading

lkingland commented Oct 17, 2022 •

edited

Loading