-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On cluster build without VCS #1298
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
- Coverage 47.06% 46.46% -0.61%
==========================================
Files 73 73
Lines 10338 10473 +135
==========================================
Hits 4866 4866
- Misses 5049 5184 +135
Partials 423 423
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4d56d8e
to
5493684
Compare
@lkingland @lance PTAL |
/easycla |
5493684
to
8386b67
Compare
Codecov ReportBase: 59.80% // Head: 60.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
+ Coverage 59.80% 60.48% +0.67%
==========================================
Files 73 75 +2
Lines 10440 10639 +199
==========================================
+ Hits 6244 6435 +191
+ Misses 3679 3666 -13
- Partials 517 538 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@zroubalik PTAL |
@salaboy PTAL |
10edecb
to
2510730
Compare
6524cda
to
2425081
Compare
@jrangelramos PTAL |
I think a nice to have would be perform a check for |
I tested this on On |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Added @jrangelramos ' suggestion to evaluate .gitignore as #1298
/lgtm
/hold for optional, very minor suggestions inline
@lkingland I added e2e test, please re-lgtm. |
@zroubalik @lance PTAL |
/lgtm |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Co-authored-by: Lance Ball <lball@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
6bd863a
to
d61b6b7
Compare
Signed-off-by: Matej Vasek <mvasek@redhat.com>
d61b6b7
to
46495ba
Compare
I did a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
great work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we are good to go @lance . |
/lgtm |
/unhold |
* refactor: attach() and podReady() more general Signed-off-by: Matej Vasek <mvasek@redhat.com> * feat: added function for upload to a volume Signed-off-by: Matej Vasek <mvasek@redhat.com> * refactor: extract defaultSecurityContext Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: added runtime type check Signed-off-by: Matej Vasek <mvasek@redhat.com> * feat: allow on-cluster-build without VCS Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: reword error message Co-authored-by: Lance Ball <lball@redhat.com> * fix: runtime type check Signed-off-by: Matej Vasek <mvasek@redhat.com> * test: e2e test for direct upload on-cluster-build Signed-off-by: Matej Vasek <mvasek@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com> Co-authored-by: Lance Ball <lball@redhat.com>
Changes
/kind enhancement
Known issue: Direct upload in not working on OpenShift under privileged account.
resolves #952