builder short name constants etc throughout #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 43.34% 43.42% +0.07%
==========================================
Files 68 68
Lines 9579 9606 +27
==========================================
+ Hits 4152 4171 +19
- Misses 5032 5038 +6
- Partials 395 397 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lkingland
changed the title
lkingland
changed the title
lkingland
changed the title
lkingland
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
lkingland
commented
Aug 22, 2022
| @@ -1,33 +0,0 @@ | |||
| package function | |||
There was a problem hiding this comment.
most of this file moved to builders/builder.go
lkingland
commented
Aug 22, 2022
lkingland
force-pushed
the
lkingland/builder-constants
branch
from
f38ee47
to
f0ad9ee
Compare
lkingland
added a commit
to lkingland/func
that referenced
this pull request
Aug 22, 2022
lance
reviewed
Aug 23, 2022
lkingland
force-pushed
the
lkingland/builder-constants
branch
from
c801d99
to
e705307
Compare
|
Thanks @lace for the review. All comments should now have been processed |
|
@lkingland needs rebase - otherwise lgtm |
knative-prow-robot
added
the
needs-rebase
lkingland
force-pushed
the
lkingland/builder-constants
branch
from
e705307
to
e4a2e29
Compare
knative-prow-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out builder names, validators and error types into their own package.
Moves validators of builder names into
main, which is closest to where knowledge of the correct set resides./kind chore