Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround for missing func.yaml on tekton step result #1070

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix: workaround for missing func.yaml on tekton step result #1070

merged 1 commit into from
Jun 16, 2022

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🐛 Workaround for missing func.yaml on tekton step result of task buildpack

/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 16, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jrangelramos / name: Jefferson Ramos (c4ef896)

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #1070 (2ff8254) into main (af916e7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   47.58%   47.54%   -0.04%     
==========================================
  Files          59       59              
  Lines        7997     7997              
==========================================
- Hits         3805     3802       -3     
- Misses       3817     3819       +2     
- Partials      375      376       +1
Impacted Files Coverage Δ
s2i/builder.go 68.14% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af916e7...2ff8254. Read the comment docs.

zroubalik
zroubalik reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, so we are able to maintain this in the future.

pipelines/resources/tekton/task/func-buildpacks/0.1/func-buildpacks.yaml Outdated Show resolved Hide resolved
pipelines/resources/tekton/task/func-buildpacks/0.1/func-buildpacks.yaml Show resolved Hide resolved
pipelines/resources/tekton/task/func-buildpacks/0.1/func-buildpacks.yaml Outdated Show resolved Hide resolved
pipelines/resources/tekton/task/func-buildpacks/0.1/func-buildpacks.yaml Show resolved Hide resolved
@lance
Copy link
Member

lance commented Jun 16, 2022

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2022
zroubalik
zroubalik approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d1dc7e6 into knative:main Jun 16, 2022
@jrangelramos jrangelramos deleted the tekton-empty-source-fix branch June 16, 2022 18:20
@lance lance mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees

@zroubalik zroubalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrangelramos @lance @zroubalik