Skip to content

Commit

Permalink
Review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
lkingland committed Feb 29, 2024
1 parent 2cc0396 commit 6e6b96d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/functions/client_int_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ func Handle(ctx context.Context, w http.ResponseWriter, req *http.Request) {
func newClient(verbose bool) *fn.Client {
builder := buildpacks.NewBuilder(buildpacks.WithVerbose(verbose))
pusher := docker.NewPusher(docker.WithVerbose(verbose))
deployer := knative.NewDeployer(knative.WithDeployerNamespace(DefaultNamespace), knative.WithDeployerVerbose(verbose))
deployer := knative.NewDeployer(knative.WithDeployerVerbose(verbose))
describer := knative.NewDescriber(DefaultNamespace, verbose)
remover := knative.NewRemover(verbose)
lister := knative.NewLister(DefaultNamespace, verbose)
Expand Down
2 changes: 1 addition & 1 deletion pkg/knative/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func TestIntegration(t *testing.T) {
_ = knative.GetKServiceLogs(ctx, namespace, functionName, function.Deploy.Image, &now, buff)
}()

deployer := knative.NewDeployer(knative.WithDeployerNamespace(namespace), knative.WithDeployerVerbose(false))
deployer := knative.NewDeployer(knative.WithDeployerVerbose(false))

depRes, err := deployer.Deploy(ctx, function)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions pkg/testing/testing.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,9 @@ func RunGitServer(root string, t *testing.T) (url string) {
}

// FromTempDirectory moves the test into a new temporary directory and
// clears all known interfereing environment variables. Returned is the
// clears all known interfering environment variables. Returned is the
// path to the somewhat isolated test environment.
// Note that KUBECONFIG is also set to testdata/default_kubeconfig whcih can
// Note that KUBECONFIG is also set to testdata/default_kubeconfig which can
// be used for tests which are explicitly checking logic which depends on
// kube context.
func FromTempDirectory(t *testing.T) string {
Expand Down

0 comments on commit 6e6b96d

Please sign in to comment.