Bump KafkaChannel types to v1beta1

[aliok]

Fixes #1351

Proposed Changes

• v1beta1 type bump for KafkaChannel

Release Note

Docs

[knative-prow-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mattmoor]

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

[aliok]

We need this to support duckv1, right?

[matzew]

yep

[aliok]

Should I change this line with

eventingduckv1.ChannelableSpec `json:",inline"`

similar to InMemoryChannel v1?

We'd also have a Delivery *DeliverySpec in that case in KafkaChannelSpec

More context: https://knative.slack.com/archives/CR2141CGY/p1593428283210700

[aliok]

cc @n3wscott

[vaikas]

Yea and also the Status

[matzew]

@aliok something like:

// KafkaChannelSpec defines the specification for a KafkaChannel.
type KafkaChannelSpec struct {
    // NumPartitions is the number of partitions of a Kafka topic. By default, it is set to 1.
    NumPartitions int32 `json:"numPartitions"`

    // ReplicationFactor is the replication factor of a Kafka topic. By default, it is set to 1.
    ReplicationFactor int16 `json:"replicationFactor"`

    // Channel conforms to Duck type Channelable.
    eventingduck.ChannelableSpec `json:",inline"`
}

// KafkaChannelStatus represents the current state of a KafkaChannel.
type KafkaChannelStatus struct {
    // Channel conforms to Duck type Channelable.
    eventingduck.ChannelableStatus `json:",inline"`
}

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
kafka/channel/pkg/apis/messaging/v1beta1/kafka_channel_defaults.go	Do not exist	100.0%
kafka/channel/pkg/apis/messaging/v1beta1/kafka_channel_lifecycle.go	Do not exist	84.4%
kafka/channel/pkg/apis/messaging/v1beta1/kafka_channel_types.go	Do not exist	100.0%
kafka/channel/pkg/apis/messaging/v1beta1/kafka_channel_validation.go	Do not exist	100.0%
kafka/channel/pkg/apis/messaging/v1beta1/register.go	Do not exist	0.0%

[knative-prow-robot]

@aliok: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-eventing-contrib-go-coverage	46b876d	link	/test pull-knative-eventing-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aliok]

cc @lionelvillard @matzew
Please ignore the failing coverage

[matzew]

/lgtm
/approve

I will follow up w/ a PR for the types

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [matzew]
• kafka/OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment