Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Enable sources conformance tests and add Source CRD Metadata test #1334

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Jun 23, 2020

Fixes #3116

Proposed Changes

  • Enable sources conformance tests for CamelSource and KafkaSource
  • Add Source CRD Metadata test

Release Note

CamelSource and KafkaSource started having some conformance tests that run regularly.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2020
@devguyio
Copy link
Contributor Author

/assign @aliok

@aliok
Copy link
Member

aliok commented Jun 23, 2020

/assign

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

All good!
I can see the source conformance tests running in the logs for multiple sources.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@slinkydeveloper
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, aliok, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@knative-prow-robot knative-prow-robot merged commit 3a505ad into knative:master Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants