src: simplify go templates #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
kind/enhancement
size/M
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
=======================================
Coverage 41.52% 41.52%
=======================================
Files 42 42
Lines 4101 4101
=======================================
Hits 1703 1703
Misses 2145 2145
Partials 253 253 Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In user interviews it was recommended that we have all complexity in the templates pushed to the bottom, and a large "your code here" callout in the initial function to make the initial experience by developers better. This was also brought up again in #606. This PR proposes a format which, if acceptable, may serve as a template for the other embedded templates as well. There is a more in-depth discussion there as to why this particular function signature was chosen as the default for Cloud Events that may be worth a read for those so inclined.
/kind enhancement
Fixes #606