-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: simplify go templates #741
src: simplify go templates #741
Conversation
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
=======================================
Coverage 41.52% 41.52%
=======================================
Files 42 42
Lines 4101 4101
=======================================
Hits 1703 1703
Misses 2145 2145
Partials 253 253 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Looking good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
In user interviews it was recommended that we have all complexity in the templates pushed to the bottom, and a large "your code here" callout in the initial function to make the initial experience by developers better. This was also brought up again in #606. This PR proposes a format which, if acceptable, may serve as a template for the other embedded templates as well. There is a more in-depth discussion there as to why this particular function signature was chosen as the default for Cloud Events that may be worth a read for those so inclined.
/kind enhancement
Fixes #606