Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to disable pushing of image in deploy command #739

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jan 6, 2022

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

This is needed to have standalone deploy Tekton task.

Basically implementing the same functionality that has been done in #681 for build.

Changes

  • 🎁 add possibility to disable pushing of image in deploy command

/kind enhancement

Relates: #620

Enable 'func deploy' without pushing an image using the --push or -u flag

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@knative-prow-robot knative-prow-robot added kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #739 (d813244) into main (2282cf8) will decrease coverage by 0.03%.
The diff coverage is 28.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   41.56%   41.52%   -0.04%     
==========================================
  Files          42       42              
  Lines        4083     4101      +18     
==========================================
+ Hits         1697     1703       +6     
- Misses       2135     2145      +10     
- Partials      251      253       +2     
Impacted Files Coverage Δ
cmd/deploy.go 15.88% <9.09%> (-0.29%) ⬇️
client.go 64.28% <33.33%> (-0.81%) ⬇️
cmd/build.go 59.42% <85.71%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2282cf8...d813244. Read the comment docs.

@zroubalik
Copy link
Contributor Author

This should be ready for review and merge.

cmd/deploy.go Outdated Show resolved Hide resolved
cmd/build_test.go Outdated Show resolved Hide resolved
Zbynek Roubalik added 2 commits January 6, 2022 19:21
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@knative-prow-robot knative-prow-robot merged commit 64ba17b into knative:main Jan 7, 2022
jrangelramos added a commit to jrangelramos/func that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants