Add identity information to the "Add to Slack" flow. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est, rather than rely on identity.basic which can not be combined with the other scopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is well known that Slack requires identity scopes to be separate from additional scopes. This typically requires pushing a user down the OAuth flow twice (once for "Sign in with Slack" and one with "Add to Slack").
This solution addresses that by gathering the information normally in the identity scopes from the "Add to Slack" flow by calling the
auth.testandusers.infoAPIs and stuffing the data conditionally.Also, allow
redirect_urito be defined on the configuration.I would like to see this get merged into master.