fix: Default methods should be lifecycle methods

Fixes #318
klum-dsl · Mar 7, 2024 · eb292e4 · eb292e4
1 parent 6bc76ef
commit eb292e4
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/klum-ast-annotations/src/main/java/com/blackbuild/groovy/configdsl/transform/Default.java b/klum-ast-annotations/src/main/java/com/blackbuild/groovy/configdsl/transform/Default.java
@@ -25,7 +25,6 @@
 
 import com.blackbuild.groovy.configdsl.transform.cast.NeedsDSLClass;
 import com.blackbuild.klum.cast.KlumCastValidated;
-import com.blackbuild.klum.cast.checks.ClassNeedsAnnotation;
 import com.blackbuild.klum.cast.checks.NeedsOneOf;
 import com.blackbuild.klum.cast.checks.OnlyOn;
 import groovy.lang.Closure;
@@ -86,6 +85,7 @@
 @Target({ElementType.FIELD, ElementType.METHOD})
 @Retention(RetentionPolicy.RUNTIME)
 @KlumCastValidated
+@WriteAccess
 @NeedsDSLClass
 @NeedsOneOf(whenOn = ElementType.FIELD, value = {"field", "delegate", "code"}, exclusive = true)
 @Documented

diff --git a/klum-ast/src/test/groovy/com/blackbuild/groovy/configdsl/transform/DefaultValuesSpec.groovy b/klum-ast/src/test/groovy/com/blackbuild/groovy/configdsl/transform/DefaultValuesSpec.groovy
@@ -27,6 +27,7 @@ package com.blackbuild.groovy.configdsl.transform
 
 import org.codehaus.groovy.control.MultipleCompilationErrorsException
 import spock.lang.Ignore
+import spock.lang.Issue
 
 class DefaultValuesSpec extends AbstractDSLSpec {
 
@@ -288,4 +289,32 @@ class DefaultValuesSpec extends AbstractDSLSpec {
         foo.value == "model"
     }
 
+    @Issue("318")
+    def "default methods should be lifecycle methods"() {
+        when:
+        createClass '''
+            package pk
+
+            @DSL
+            class Foo {
+                String value
+                @Default
+                void aDefaultMethod() {
+                    value = "default"
+                }
+            }
+        '''
+
+        then:
+        notThrown(MultipleCompilationErrorsException)
+        hasNoMethod(clazz, "aDefaultMethod")
+        hasNoMethod(rwClazz, "aDefaultMethod")
+
+        when:
+        def foo = create("pk.Foo")
+
+        then:
+        foo.value == "default"
+    }
+
 }