Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build job, more declarative package metadata #83

Merged
merged 3 commits into from
May 17, 2021

Conversation

bollwyvl
Copy link
Contributor

A couple things here:

  • as per add remaining test data #81, shows a CI approach that primarily tests the code-as-distributed
    • an up-front build job (with no matrix)
    • builds the distribution artifacts
    • runs the linter
    • tests code-in-source will keep the coverage file names the same
    • uploads coverage
    • uploads the artifacts
    • the test matrix job:
      • downloads the artifacts
      • picks one to install (kind of annoying, because platform differences, and globs on windows)
      • runs the tests
  • In working that up, moved a lot of the static (and dynamic) setup.py stuff to setup.cfg, as modern (last two years or so) setuptools does a lot more of the heavy lifting now, e.g. worrying about encodings, etc.
    • it doesn't do requirements.txt, but it may be worth moving those to the canonical install_requires
    • tests_require could also be added... but pip won't install extras from a local artifact, so it still can't be a single source of truth without weird gotchas

@klieret
Copy link
Owner

klieret commented May 14, 2021

Thank you so much ❤️ I will take a look at it tomorrow, sorry for being a bit slow (also with the RandomFileTree pull requests)

@klieret
Copy link
Owner

klieret commented May 17, 2021

Took me some time to read through all the changes, but it's great stuff (and I learned a lot)!

@klieret klieret merged commit f76d703 into klieret:master May 17, 2021
@klieret
Copy link
Owner

klieret commented May 17, 2021

tests_require could also be added... but pip won't install extras from a local artifact, so it still can't be a single source of truth without weird gotchas

Hmm, we might get this to work with a combination of this and this though, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants