Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to pexpect's bashrc #485

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 12, 2024

Fix path to pexpect's bashrc, to make tests more reliable. The path was changed in 46e6e75 to replwrap/bashrc.sh inside pexpect package; however, FWICS no such directory ever existed and the bashrc file was always directly inside the package directory.

Without this change, pexpect's bashrc is not loaded and tests fail when user's bashrc results in a long prompt. In my case, they failed on a system with a 12-character hostname (and passed on a system with a 6-character hostname).

Fix path to pexpect's bashrc, to make tests more reliable.  The path
was changed in 46e6e75
to `replwrap/bashrc.sh` inside pexpect package; however, FWICS no such
directory ever existed and the bashrc file was always directly inside
the package directory.

Without this change, pexpect's bashrc is not loaded and tests fail
when user's bashrc results in a long prompt.  In my case, they failed
on a system with a 12-character hostname (and passed on a system
with a 6-character hostname).
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (c7cc834) to head (d60a9cc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #485      +/-   ##
===========================================
+ Coverage    81.09%   81.21%   +0.12%     
===========================================
  Files           10       10              
  Lines          788      788              
===========================================
+ Hits           639      640       +1     
+ Misses         149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislyuk kislyuk merged commit 6c9e540 into kislyuk:develop May 12, 2024
24 checks passed
@kislyuk
Copy link
Owner

kislyuk commented May 12, 2024

Thanks!

@mgorny mgorny deleted the pexpect-bashrc branch May 13, 2024 01:00
@mgorny
Copy link
Contributor Author

mgorny commented May 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants