forked from dotnet/tye
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address feedback about how we do evaluation
Fixes: dotnet#362 This change splits up our evaluation code-path into a few steps: - Load project - Do a restore - Mark dirty - Run targets and read properties The key is that we need to do a restore separately from other targets because restore will bring in nuget packages that contain targets. You need to let MSBuild load those before continuing. The code here is pretty similar to what dotnet does. Additionally blocking the NBGV scenario, there are some additional assemblies that need to be provided by MSBuild. NBGV also loads Microsoft.DotNet.Platform.Abstractions which is part of the SDK. Since we had an allow-list of just nuget assemblies that wasn't resolved.
- Loading branch information
1 parent
9553bd4
commit 63b4d1a
Showing
1 changed file
with
50 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters